1345981 - Move page info tests out of browser/base/content/test/general

Status: RESOLVED FIXED

(Firefox :: Page Info Window, enhancement)

Description

[Mark Banner (:standard8)]

Seeing as we have browser/base/content/pageinfo, I think it makes sense to create a browser/base/content/test/pageinfo directory as well (especially as general is getting too big).

As I'm going to be working on a bug that will want to add another page info test, it seems to be worth moving these out of general ahead of that.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1345981 - Move page info tests out of browser/base/content/test/general.

Review commit: https://reviewboard.mozilla.org/r/118736/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118736/

Comment 2

[:Gijs (he/him)]

Comment on attachment 8845604 [details]
Bug 1345981 - Move page info tests out of browser/base/content/test/general.

https://reviewboard.mozilla.org/r/118736/#review121014

Thanks for this, and also for making the test names more meaningful!

::: browser/base/content/test/pageinfo/browser.ini:3
(Diff revision 1)
> +[DEFAULT]
> +support-files =
> +  ../general/feed_tab.html

Nit: please add this to the relevant test instead.

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8845604 [details]
Bug 1345981 - Move page info tests out of browser/base/content/test/general.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/118736/diff/1-2/

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 8845604 [details]
Bug 1345981 - Move page info tests out of browser/base/content/test/general.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/118736/diff/2-3/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2591fea9098d
Move page info tests out of browser/base/content/test/general. r=Gijs

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2591fea9098d