Closed Bug 1345981 Opened 7 years ago Closed 7 years ago

Move page info tests out of browser/base/content/test/general

Categories

(Firefox :: Page Info Window, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox55 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Seeing as we have browser/base/content/pageinfo, I think it makes sense to create a browser/base/content/test/pageinfo directory as well (especially as general is getting too big).

As I'm going to be working on a bug that will want to add another page info test, it seems to be worth moving these out of general ahead of that.
Blocks: 1345991
Comment on attachment 8845604 [details]
Bug 1345981 - Move page info tests out of browser/base/content/test/general.

https://reviewboard.mozilla.org/r/118736/#review121014

Thanks for this, and also for making the test names more meaningful!

::: browser/base/content/test/pageinfo/browser.ini:3
(Diff revision 1)
> +[DEFAULT]
> +support-files =
> +  ../general/feed_tab.html

Nit: please add this to the relevant test instead.
Attachment #8845604 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2591fea9098d
Move page info tests out of browser/base/content/test/general. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/2591fea9098d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: