1346010 - [wasm] wasmBinaryToText->wasmTextToBinary round-trip fails

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Yury Delendik (:yury)]

Attachment: test case

The attached js test fails with:

test.js:1:1 SyntaxError: wasm text error: Function label '$global0' not found
Stack:
  @test.js:1:1

The original wast code is generated by s2wasm.

Comment 1

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1346010: Properly render the name of func imports when there's at least one non-func import;

Review commit: https://reviewboard.mozilla.org/r/118992/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/118992/

Comment 2

[Yury Delendik (:yury)]

Comment on attachment 8845855 [details]
Bug 1346010: Properly render the name of func imports when there's at least one non-func import;

https://reviewboard.mozilla.org/r/118992/#review121020

Looks good. Thank you.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d073b71458b
Properly render the name of func imports when there's at least one non-func import; r=yury

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0d073b71458b

Comment 5

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8845855 [details]
Bug 1346010: Properly render the name of func imports when there's at least one non-func import;

Approval Request Comment
[Feature/Bug causing the regression]: probably bug 1310949
[User impact if declined]: incorrect rendering/debugging of wasm programs (54 should have debugger support)
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: yes
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: not much
[Why is the change risky/not risky?]: very small targeted fix
[String changes made/needed]: n/a

Comment 6

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 8845855 [details]
Bug 1346010: Properly render the name of func imports when there's at least one non-func import;

wasm fix for aurora54

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2816763298de