Closed Bug 1346107 Opened 9 years ago Closed 9 years ago

WrDisplayItemLayer causes panic with advanced layers

Categories

(Core :: Graphics: WebRender, enhancement)

Product:
Core
Component:
Graphics: WebRender
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: rhunt, Unassigned)

Details

(Whiteboard: [gfx-noted])

When turning on all the advanced layers prefs in [1] for a wr demo, webrender hits a panic in [2]. The problem is that some display items like nsButtonFrameRender end up pushing a stacking context which pushes a scroll layer which causes the panic. [1] https://public.etherpad-mozilla.org/p/gfx-wr-demo [2] https://hg.mozilla.org/projects/graphics/file/855b9296185f/gfx/webrender_traits/src/display_list.rs#l361 [3] https://hg.mozilla.org/projects/graphics/file/855b9296185f/layout/forms/nsButtonFrameRenderer.cpp#l241
I see the comment says this will be going away sometime. Is that soon or should this be fixed separately?
Flags: needinfo?(jmuizelaar)
This should be easy to fix. I'll do it this morning.
Flags: needinfo?(jmuizelaar)
That being said do we actually need a ScrollFrame to render these things? If not, this code should be refactored to avoid the ScrollFrame.
In fact, bug 1346110 should fix this.
This specific issue has been resolved by bug 1346110.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.