1346141 - Implement basic wr support for TableBorderBackground

Status: RESOLVED INVALID

(Core :: Graphics: WebRender, enhancement)

Description

[Ethan Lin[:ethlin]]

In this bug I will just add some functions in nsDisplayTableBorderBackground to generate DisplayItemLayer and pref. And implement the border rendering for non-collapse case.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: add basic wr support

I add basic DisplayItemLayer support for nsDisplayTableBorderBackground in this patch. So more people can work on the conversion of this item.

Comment 2

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8845801 [details] [diff] [review]
add basic wr support

Review of attachment 8845801 [details] [diff] [review]:
-----------------------------------------------------------------

Won't this fail to paint the table background?

I think we should do the same as other place and try to refactor the code so that the normal paint path uses the border renderer object too.

Comment 3

[Ethan Lin[:ethlin]]

(In reply to Matt Woodrow (:mattwoodrow) from comment #2)
> Comment on attachment 8845801 [details] [diff] [review]
> add basic wr support
> 
> Review of attachment 8845801 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Won't this fail to paint the table background?
> 
> I think we should do the same as other place and try to refactor the code so
> that the normal paint path uses the border renderer object too.

Oh..you are right. I didn't think it clearly. Originally I want to do the refactoring in other bugs and this one is just for creating DisplayItemLayer. But looks like at least I should handle table background painting or the result will be totally wrong.