Closed Bug 1346171 Opened 3 years ago Closed 3 years ago

Fix stupid copy-paste error when deleting session files

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 55
Tracking Status
firefox52 --- wontfix
firefox53 --- fixed
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: JanH, Assigned: JanH)

References

Details

Attachments

(2 files)

Blocks: 1266594
Comment on attachment 8846404 [details]
Bug 1346171 - Part 1 - Check correct file before attempting do delete it.

https://reviewboard.mozilla.org/r/119446/#review121468
Attachment #8846404 - Flags: review?(s.kaspari) → review+
Comment on attachment 8846405 [details]
Bug 1346171 - Part 2 - Test synchronous session file deletion on clearing history.

https://reviewboard.mozilla.org/r/119448/#review121470
Attachment #8846405 - Flags: review?(s.kaspari) → review+
Pushed by mozilla@buttercookie.de:
https://hg.mozilla.org/integration/autoland/rev/303b1628ce44
Part 1 - Check correct file before attempting do delete it. r=sebastian
https://hg.mozilla.org/integration/autoland/rev/0be73c1886dd
Part 2 - Test synchronous session file deletion on clearing history. r=sebastian
Comment on attachment 8846404 [details]
Bug 1346171 - Part 1 - Check correct file before attempting do delete it.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1266594
[User impact if declined]: When clearing history on shutdown, some sessions store files might not be cleaned up.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: No, but verified locally.
[Needs manual test from QE? If yes, steps to reproduce]:  No.
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: No.
[Why is the change risky/not risky?]: Just changed check whether file exists to use the correct file.
[String changes made/needed]: none
Attachment #8846404 - Flags: approval-mozilla-beta?
Attachment #8846404 - Flags: approval-mozilla-aurora?
Comment on attachment 8846405 [details]
Bug 1346171 - Part 2 - Test synchronous session file deletion on clearing history.

See Part 1 for the rest.
[List of other uplifts needed for the feature/fix]: Test modified here was introduced in bug 1343603 part 2, but that has already been uplifted to Aurora and Beta.
Attachment #8846405 - Flags: approval-mozilla-beta?
Attachment #8846405 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/303b1628ce44
https://hg.mozilla.org/mozilla-central/rev/0be73c1886dd
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Comment on attachment 8846404 [details]
Bug 1346171 - Part 1 - Check correct file before attempting do delete it.

Fix for regression from 52, let's uplift to beta.
Attachment #8846404 - Flags: approval-mozilla-beta?
Attachment #8846404 - Flags: approval-mozilla-beta+
Attachment #8846404 - Flags: approval-mozilla-aurora?
Attachment #8846404 - Flags: approval-mozilla-aurora+
Comment on attachment 8846405 [details]
Bug 1346171 - Part 2 - Test synchronous session file deletion on clearing history.

Thanks for the test fixes.
Attachment #8846405 - Flags: approval-mozilla-beta?
Attachment #8846405 - Flags: approval-mozilla-beta+
Attachment #8846405 - Flags: approval-mozilla-aurora?
Attachment #8846405 - Flags: approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.