1346179 - Update Debugger frontend (3/10/2017)

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Jason Laster [:jlast]]

This is a small bug-fix update, which will hopefully be uplifted to aurora.

Comment 1

[Jason Laster [:jlast]]

Attachment: bundle3-10.patch

[Is this code covered by automated tests?]: Yes
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]:  No
[List of other uplifts needed for the feature/fix]: 
[Is the change risky?]: Small risk of regression
[Why is the change risky/not risky?]: The changes have landed over this week in github.com/devtools-html/debugger.html/.
[String changes made/needed]: none

Comment 2

[Jason Laster [:jlast]]

Attachment: bundle3-10-1.patch

- aurora rationale is the same as above
- the patch is identical, except for one l10n key change

Comment 3

[Jason Laster [:jlast]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a2f167f864e806c05f139a264f212fc0ca318774

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8845877 [details] [diff] [review]
bundle3-10-1.patch

Review of attachment 8845877 [details] [diff] [review]:
-----------------------------------------------------------------

Great! 

As discussed, just revert the l10n key to editor.jumpToMappedLocation1 and update references in the bundle accordingly.

Comment 5

[Jason Laster [:jlast]]

Attachment: bundle3-10-2.patch

This is a small patch to remove the properties change.

aurora rationale: same as above

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/10219ec758f8
Update debugger frontend 3/10/2017. r=jdescottes

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/10219ec758f8

Comment 8

[Gerry Chang [:gchang]]

Hi :jlast,
There is no [Feature/Bug causing the regression] specified in the uplift template. Is there any specific reason that why we need this in aurora? If not, I prefer we let this patch ride the train.
We usualy take the uplifts that are fixes of features or the bug causing regression in previous versions. For new features/impmentations, we will let them ride the train.

Comment 9

[Jason Laster [:jlast]]

Sorry for the slow reply :gchang.

This fixes some regressions with the new debugger frontend vertical mode and variable preview. This is low risk as the new frontend will be off by default, but it would still be nice to be able to have the best possible experience.

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8845999 [details] [diff] [review]
bundle3-10-2.patch

Per comment #9, it's default off. I prefer to let it ride the train on 55 and won't fix in 54. Aurora54-.