1346203 - CANVAS_WEBGL_FAILURE_ID records values using empty keys

Status: RESOLVED FIXED

(Core :: Graphics: Layers, enhancement, P1)

Description

[Alessio Placitelli [:Dexter]]

With bug 1334469 we're disallowing using empty keys to record data in Telemetry keyed histograms.

It seems that this histogram is recording values using empty keys (see bug 1334469 comment 20).

For some reason, |failureId| and/or |cur.key| are empty [1]. We should fix the problem by using a non-empty key here and investigate why and empty key is used in the first place.

[1] - http://searchfox.org/mozilla-central/rev/7cb75d87753de9103253e34bc85592e26378f506/dom/canvas/WebGLContext.cpp#878,939,1014

Comment 1

[Sotaro Ikeda [:sotaro]]

:pchang, can you find someone to take a look?

Comment 2

[Alessio Placitelli [:Dexter]]

Attachment: Bug 1346203 - Don't use an empty key for accumulating in CANVAS_WEBGL_FAILURE_ID.

Review commit: https://reviewboard.mozilla.org/r/132396/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/132396/

Comment 3

[Alessio Placitelli [:Dexter]]

I too this bug so that we can move on and land bug 1334469, when ready! :-)

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 8860381 [details]
Bug 1346203 - Don't use an empty key for accumulating in CANVAS_WEBGL_FAILURE_ID.

https://reviewboard.mozilla.org/r/132396/#review135300

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ca43af8102f
Don't use an empty key for accumulating in CANVAS_WEBGL_FAILURE_ID. r=jrmuizel

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6ca43af8102f