Closed
Bug 1346208
Opened 7 years ago
Closed 7 years ago
Remove B2G-specific code from Telemetry C++ modules
Categories
(Toolkit :: Telemetry, enhancement, P4)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: gfritzsche, Assigned: clintonfeng, Mentored)
Details
(Whiteboard: [measurement:client] [lang=c++] [good first bug])
Attachments
(1 file, 2 obsolete files)
B2G / Firefox OS / Gonk is not a supported platform anymore. We should remove the B2G/Gonk logic from the Telemetry C++ files: https://dxr.mozilla.org/mozilla-central/search?q=path%3Atoolkit%2Fcomponents%2Ftelemetry+gonk+ext%3Acpp+ext%3Ah&redirect=false
|
Assignee | |
Comment 1•7 years ago
|
||
Hello, Im pretty sure I have done what you have asked. What I did is I removed "!defined(MOZ_WIDGET_GONK) &&" from the code which hopefully is right. Im currently trying to figure out how to submit a patch.
|
|
Assignee | |
Comment 2•7 years ago
|
||
|
|
Assignee | |
Comment 3•7 years ago
|
||
|
Reporter | |
Comment 4•7 years ago
|
||
Hi Clinton, it looks like you ended up submitting the full source file, not a patch. See here for documentation on submitting patches: https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F Before asking for feedback, please make sure that, with your changes: - the build succeeds: mach build - the Telemetry unit tests run fine: mach test toolkit/components/telemetry/tests/unit
Assignee: nobody → clintonfeng
| Comment hidden (mozreview-request) |
|
|
Assignee | |
Comment 6•7 years ago
|
||
The build works and the tests run fine on my machine. I submitted a patch via mozreview and hopefully I have done it right this time.
|
|
Reporter | |
Updated•7 years ago
|
Attachment #8846280 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•7 years ago
|
Attachment #8846279 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 7•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8846369 [details] Bug 1346208 - Remove B2G-specific code from Telemetry C++ modules https://reviewboard.mozilla.org/r/119426/#review121640 Thanks, this looks good! I'll push it to our try server (dry run of our CI test runs) to make sure this is fine across platforms.
Attachment #8846369 -
Flags: review?(gfritzsche) → review+
Pushed by georg.fritzsche@googlemail.com: https://hg.mozilla.org/integration/autoland/rev/487f495d8d1d Remove B2G-specific code from Telemetry C++ modules r=gfritzsche
|
||
Comment 9•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/487f495d8d1d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•