59 bytes, text/x-review-board-request
B2G / Firefox OS / Gonk is not a supported platform anymore. We should remove the B2G/Gonk logic from the Telemetry C++ files: https://dxr.mozilla.org/mozilla-central/search?q=path%3Atoolkit%2Fcomponents%2Ftelemetry+gonk+ext%3Acpp+ext%3Ah&redirect=false
Hello, Im pretty sure I have done what you have asked. What I did is I removed "!defined(MOZ_WIDGET_GONK) &&" from the code which hopefully is right. Im currently trying to figure out how to submit a patch.
Hi Clinton, it looks like you ended up submitting the full source file, not a patch. See here for documentation on submitting patches: https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F Before asking for feedback, please make sure that, with your changes: - the build succeeds: mach build - the Telemetry unit tests run fine: mach test toolkit/components/telemetry/tests/unit
Assignee: nobody → clintonfeng
The build works and the tests run fine on my machine. I submitted a patch via mozreview and hopefully I have done it right this time.
Attachment #8846280 - Attachment is obsolete: true
Attachment #8846279 - Attachment is obsolete: true
Comment on attachment 8846369 [details] Bug 1346208 - Remove B2G-specific code from Telemetry C++ modules https://reviewboard.mozilla.org/r/119426/#review121640 Thanks, this looks good! I'll push it to our try server (dry run of our CI test runs) to make sure this is fine across platforms.
Attachment #8846369 - Flags: review?(gfritzsche) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/487f495d8d1d Remove B2G-specific code from Telemetry C++ modules r=gfritzsche
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.