Remove B2G-specific code from Telemetry C++ modules

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Telemetry
P4
normal
RESOLVED FIXED
2 months ago
a month ago

People

(Reporter: gfritzsche, Assigned: Clinton Feng, Mentored)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [measurement:client] [lang=c++] [good first bug])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

2 months ago
B2G / Firefox OS / Gonk is not a supported platform anymore.

We should remove the B2G/Gonk logic from the Telemetry C++ files:
https://dxr.mozilla.org/mozilla-central/search?q=path%3Atoolkit%2Fcomponents%2Ftelemetry+gonk+ext%3Acpp+ext%3Ah&redirect=false
(Assignee)

Comment 1

2 months ago
Hello,
Im pretty sure I have done what you have asked. What I did is I removed "!defined(MOZ_WIDGET_GONK) &&" from the code which hopefully is right. Im currently trying to figure out how to submit a patch.
(Assignee)

Comment 2

2 months ago
Created attachment 8846279 [details] [diff] [review]
TelemetryHistogram.cpp
(Assignee)

Comment 3

2 months ago
Created attachment 8846280 [details] [diff] [review]
Telemetry.cpp
(Reporter)

Comment 4

2 months ago
Hi Clinton,
it looks like you ended up submitting the full source file, not a patch.

See here for documentation on submitting patches:
https://developer.mozilla.org/en-US/docs/Mercurial/Using_Mercurial#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Before asking for feedback, please make sure that, with your changes:
- the build succeeds: mach build
- the Telemetry unit tests run fine: mach test toolkit/components/telemetry/tests/unit
Assignee: nobody → clintonfeng
Comment hidden (mozreview-request)
(Assignee)

Comment 6

2 months ago
The build works and the tests run fine on my machine. I submitted a patch via mozreview and hopefully I have done it right this time.
(Reporter)

Updated

a month ago
Attachment #8846280 - Attachment is obsolete: true
(Reporter)

Updated

a month ago
Attachment #8846279 - Attachment is obsolete: true
(Reporter)

Comment 7

a month ago
mozreview-review
Comment on attachment 8846369 [details]
Bug 1346208 - Remove B2G-specific code from Telemetry C++ modules

https://reviewboard.mozilla.org/r/119426/#review121640

Thanks, this looks good!
I'll push it to our try server (dry run of our CI test runs) to make sure this is fine across platforms.
Attachment #8846369 - Flags: review?(gfritzsche) → review+

Comment 8

a month ago
Pushed by georg.fritzsche@googlemail.com:
https://hg.mozilla.org/integration/autoland/rev/487f495d8d1d
Remove B2G-specific code from Telemetry C++ modules r=gfritzsche

Comment 9

a month ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/487f495d8d1d
Status: NEW → RESOLVED
Last Resolved: a month ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.