Closed Bug 1346451 Opened 3 years ago Closed 3 years ago

Delete WebRenderBorderLayer

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: mchang, Assigned: mchang)

References

Details

Attachments

(1 file)

We have a couple of other display items that basically recreate webrender border layer. After thinking about it, the only reason we have a border layer at all is because of advanced layers, but borders shouldn't have to create a stacking context and all. Instead, we can just reuse the border renderer. Let's remove the WR Border Layer.
Attachment #8846199 - Flags: review?(ethlin)
Comment on attachment 8846199 [details] [diff] [review]
Remove WRBorderLayer

Review of attachment 8846199 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: layout/painting/nsDisplayList.cpp
@@ +4636,5 @@
> +                                         mFrame->StyleContext(),
> +                                         mFrame->GetSkipSides());
> +
> +  if (!br) {
> +    NS_WARNING("Could not create border renderer during nsDisplayButtonBorder");

should be 'nsDisplayBorder'.
Attachment #8846199 - Flags: review?(ethlin) → review+
Blocks: 1346701
Pushed by mchang@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/fbb9ff0ea41d
Delete WebRenderBorderLayer. r=ethlin
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.