1346451 - Delete WebRenderBorderLayer

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Mason Chang [Inactive] [:mchang]]

Attachment: Remove WRBorderLayer

We have a couple of other display items that basically recreate webrender border layer. After thinking about it, the only reason we have a border layer at all is because of advanced layers, but borders shouldn't have to create a stacking context and all. Instead, we can just reuse the border renderer. Let's remove the WR Border Layer.

Comment 1

[Ethan Lin[:ethlin]]

Comment on attachment 8846199 [details] [diff] [review]
Remove WRBorderLayer

Review of attachment 8846199 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: layout/painting/nsDisplayList.cpp
@@ +4636,5 @@
> +                                         mFrame->StyleContext(),
> +                                         mFrame->GetSkipSides());
> +
> +  if (!br) {
> +    NS_WARNING("Could not create border renderer during nsDisplayButtonBorder");

should be 'nsDisplayBorder'.

Comment 2

[Mason Chang [Inactive] [:mchang]]

Try looks good - https://treeherder.mozilla.org/#/jobs?repo=try&revision=917790c7f025a57e9123b5d2b3af0366d68c6181

Comment 3

[Mason Chang [Inactive] [:mchang]]

rebased try looks good - https://treeherder.mozilla.org/#/jobs?repo=try&revision=c716c3c9d730522f13f3b5071ee84f2a649e6d01

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/projects/graphics/rev/fbb9ff0ea41d
Delete WebRenderBorderLayer. r=ethlin

Comment 5

[Kartikaya Gupta (email:[e-mail])]

https://hg.mozilla.org/mozilla-central/rev/fbb9ff0ea41d