Closed Bug 1346481 Opened 8 years ago Closed 8 years ago

stylo: need to support skipping parent-display-based display fixup for anonymous boxes

Categories

(Core :: CSS Parsing and Computation, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

We need this at least for the combobox display frame. Without this, layout/reftests/forms/select/997709-2.html renders totally wrong.
This should be easily doable, we should just need to pass the relevant flag to precomputed_style_for_pseudo, either from servo directly, or from gecko if it's conditional depending on the frame.
This doesn't make us pass any tests, because unfortunately our rendering of <select> is still all broken.
Comment on attachment 8846244 [details] Bug 1346481. Add stylo support for skipping parent-display-based fixup for anonymous boxes. https://reviewboard.mozilla.org/r/119328/#review121272 r=me, with or without the following nit that I also left in the servo PR. ::: servo/components/script_layout_interface/wrapper_traits.rs:411 (Diff revision 1) > let new_style = > context.stylist.precomputed_values_for_pseudo( > &style_pseudo, > Some(data.styles().primary.values()), > &context.default_computed_values, > + false, I think it'd be more elegant to pass CascadeFlags directly to precomputed_values_for_pseudo. We'd pass CascadeFlags::empty() here. I don't like multiple boolean arguments in general, and should be straight-forward to do, wdyt?
Attachment #8846244 - Flags: review?(emilio+bugs) → review+
Priority: -- → P1
Comment on attachment 8846244 [details] Bug 1346481. Add stylo support for skipping parent-display-based fixup for anonymous boxes. https://reviewboard.mozilla.org/r/119328/#review121272 > I think it'd be more elegant to pass CascadeFlags directly to precomputed_values_for_pseudo. We'd pass CascadeFlags::empty() here. > > I don't like multiple boolean arguments in general, and should be straight-forward to do, wdyt? > I think it'd be more elegant to pass CascadeFlags directly to precomputed_values_for_pseudo I agree. I thought there was some reason it wasn't done that way. I'll fix it.
Pushed by ecoal95@gmail.com: https://hg.mozilla.org/integration/autoland/rev/8fd06045940a Add stylo support for skipping parent-display-based fixup for anonymous boxes. r=emilio
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: