1346644 - Disable high priority vsync handling in parent process

Status: VERIFIED FIXED

(Core :: General, defect)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Attachment: parent_process_vsync_4_backout.diff

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8846428 [details] [diff] [review]
parent_process_vsync_4_backout.diff

Approval Request Comment
[Feature/Bug causing the regression]: bug 1315570
[User impact if declined]:for example bug 1342849
[Is this code covered by automated tests?]: NA
[Has the fix been verified in Nightly?]: not yet, this is just a backout
[Needs manual test from QE? If yes, steps to reproduce]: see bug 1342849
[List of other uplifts needed for the feature/fix]: NA
[Is the change risky?]: backout, not risky
[Why is the change risky/not risky?]: see above
[String changes made/needed]: NA

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

(I'll try to figure what is causing bug 1342849 and then re-enable high-prio also in parent process, but only in case we are in multiprocess setup, so not in current Fennec.)

Comment 4

[(no longer active)]

Comment on attachment 8846428 [details] [diff] [review]
parent_process_vsync_4_backout.diff

Review of attachment 8846428 [details] [diff] [review]:
-----------------------------------------------------------------

We should probably make this be controllable by a pref the next time we re-enable...

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Maybe. That might ease some testing.
But it would apply to parent process handling only, since making the pref working for child would be quite a bit harder.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/950180909fd0
Disable high priority vsync handling in parent process, r=ehsan

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/950180909fd0

Comment 8

[Gerry Chang [:gchang]]

Hi Brindusa, could you help find someone to verify if this issue was fixed as expected on a latest Nightly build? Thanks!

Comment 9

[Hani Yacoub, Desktop QA]

Build ID: 20170314030215
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0

Verified as fixed on Firefox Nightly 55.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.

Comment 10

[Gerry Chang [:gchang]]

Comment on attachment 8846428 [details] [diff] [review]
parent_process_vsync_4_backout.diff

Backout bug 1315570. Aurora54+.

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/67bbe2d00028