1346647 - RDM icon not working when Developer Tools in undocked (separate window)

Status: VERIFIED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[viff3000]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170312084740

Steps to reproduce:

 - Open developer tools and click on 'Show in separate window' button.
 - Click on Responsive Design Mode button or use 'Ctrl-Shift-m' shortcut.

Running on Mint 18.1.



Actual results:

Nothing - unable to enter or exit RDM from the Developer Tools window.


Expected results:

Should have entered/exited RDM.

Comment 1

[Loic]

Old bug, so probably already filed. You have to focus on the tab before entering RDM with dev tools undocked.

Comment 2

[viff3000]

Tab is focused. I can enter/exit RDM from the tab itself using the keyboard shortcut, but nothing works in the Dev Tools window.

Comment 3

[Loic]

You're right, it's a recent regression. :)

Reg range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=83e1a88a9833a498a0e841e37a822de99b0ed0c6&tochange=f6895ed1367c698cd60af71084f68950cdb2e630

Alexandre Poirot — Bug 1320149 - Prevent loading gcli when opening a toolbox. r=jwalker,miker

Comment 4

[Tim Nguyen :ntim]

The browser console shows:

"browserWindow.gBrowser"

pointing to: https://dxr.mozilla.org/mozilla-central/source/devtools/client/definitions.js#516

Comment 5

[Tim Nguyen :ntim]

(In reply to Tim Nguyen :ntim from comment #4)
> The browser console shows:
> 
> "browserWindow.gBrowser"

meant "browserWindow.gBrowser is undefined"

Comment 6

[Marcia Knous [:marcia]]

Tracking 54/55+ for this recent regression in Dev Tools.

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1346647 - Fix RDM button for undocked toolbox.

Review commit: https://reviewboard.mozilla.org/r/120598/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120598/

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b80dbc323faca6fa02020c32e243964915c52f11

Comment 9

[Tim Nguyen :ntim]

Probably worth a test so we avoid regressing this.

Comment 10

[Alexandre Poirot [:ochameau]]

Comment on attachment 8847683 [details]
Bug 1346647 - Fix RDM button for undocked toolbox.

https://reviewboard.mozilla.org/r/120598/#review123382

Nice catch.
I'm wondering other usage of this "toolbox.win.top" are also wrong?
Looks like this one could be as wrong:
http://searchfox.org/mozilla-central/source/devtools/client/framework/devtools-browser.js#754

Comment 11

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Tim Nguyen :ntim from comment #9)
> Probably worth a test so we avoid regressing this.

Perhaps so!  I don't think I have time to write it right now, but I agree it would be good to have...

Comment 12

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8847683 [details]
Bug 1346647 - Fix RDM button for undocked toolbox.

https://reviewboard.mozilla.org/r/120598/#review123382

Looks like that's the only other usage of `toolbox.win.top`.  Since it landed at a different time and may or may not need uplifting, I filed bug 1348318 about this other usage.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/576abf29e19c
Fix RDM button for undocked toolbox. r=ochameau

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/576abf29e19c

Comment 15

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8847683 [details]
Bug 1346647 - Fix RDM button for undocked toolbox.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1320149 caused this when refactoring the DevTools toolbox buttons
[User impact if declined]: If declined, the button to toggle Responsive Design Mode won't work when the toolbox is undocked
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: Yes
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: None
[Is the change risky?]: No
[Why is the change risky/not risky?]: DevTools only, only affects a single button
[String changes made/needed]: None

Comment 16

[Gerry Chang [:gchang]]

Comment on attachment 8847683 [details]
Bug 1346647 - Fix RDM button for undocked toolbox.

Fix an RDM icon regression issue. Aurora54+.

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2f95244f6119

Comment 18

[Md. Majedul islam]

I have reproduced this bug with Firefox nightly 55.0a1 (2017-03-12) on Windows 10, 64 Bit.

The Bug's fix is now verified on latest nightly 55.0a1 (2017-03-22) and  latest developer edition  54.0a2 (2017-03-22) .

developer edition  54.0a2 :

Build ID  20170322004022
User Agent 	 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0
   
nightly 55.0a1:

Build ID   	20170322030208
User Agent 	 	Mozilla/5.0 (Windows NT 10.0; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0
   
[bugday-20170322]