1346713 - Generate unique firstPartyDomain for NullPrincipal everytime

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

In Bug 1300671 we have a specific firstPartyDomain assigned to NullPrincipal.
And smaug asks if we could have different firstPartyDomain each time in 
https://bugzilla.mozilla.org/show_bug.cgi?id=1300671#c19

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch.

Comment 2

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8856446 [details] [diff] [review]
Patch.

Review of attachment 8856446 [details] [diff] [review]:
-----------------------------------------------------------------

::: caps/NullPrincipal.cpp
@@ +109,5 @@
> +  OriginAttributes attrs(aOriginAttributes);
> +  // remove the {} characters from both ends.
> +  path.Mid(path, 1, path.Length() - 2);
> +  path.AppendLiteral(".mozilla");
> +  attrs.SetFirstPartyDomain(aIsFirstParty, path);

I think it's better to move these inside if (aIsFirstParty),
will update this in next patch.

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch. v2

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ce695cd46dc
Generate unique firstPartyDomain value for NullPrincipal.  r=smaug

Comment 5

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/4ce695cd46dc