Closed Bug 1346713 Opened 4 years ago Closed 4 years ago

Generate unique firstPartyDomain for NullPrincipal everytime

Categories

(Core :: DOM: Security, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: allstars.chh, Assigned: allstars.chh)

References

Details

(Whiteboard: [tor][domsecurity-active] )

Attachments

(1 file, 1 obsolete file)

In Bug 1300671 we have a specific firstPartyDomain assigned to NullPrincipal.
And smaug asks if we could have different firstPartyDomain each time in 
https://bugzilla.mozilla.org/show_bug.cgi?id=1300671#c19
Whiteboard: [tor][domsecurity-active]
Attachment #8856446 - Flags: review?(bugs) → review+
Comment on attachment 8856446 [details] [diff] [review]
Patch.

Review of attachment 8856446 [details] [diff] [review]:
-----------------------------------------------------------------

::: caps/NullPrincipal.cpp
@@ +109,5 @@
> +  OriginAttributes attrs(aOriginAttributes);
> +  // remove the {} characters from both ends.
> +  path.Mid(path, 1, path.Length() - 2);
> +  path.AppendLiteral(".mozilla");
> +  attrs.SetFirstPartyDomain(aIsFirstParty, path);

I think it's better to move these inside if (aIsFirstParty),
will update this in next patch.
Attached patch Patch. v2Splinter Review
Attachment #8856446 - Attachment is obsolete: true
Attachment #8856792 - Flags: review+
Pushed by yhuang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ce695cd46dc
Generate unique firstPartyDomain value for NullPrincipal.  r=smaug
https://hg.mozilla.org/mozilla-central/rev/4ce695cd46dc
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.