Use standard pad functions in aboutTelemetry.js

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
Telemetry
P4
normal
RESOLVED FIXED
7 months ago
3 months ago

People

(Reporter: flyingrub, Assigned: flyingrub)

Tracking

(Blocks: 1 bug)

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: [measurement:client])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170227084058

Steps to reproduce:

We use some custom padding code in aboutTelemetry.js:
https://dxr.mozilla.org/mozilla-central/search?q=path%3Atoolkit%2Fcontent%2FaboutTelemetry+pad+ext%3Ajs+ext%3Ajsm&redirect=false




Actual results:

JS now has standard padding functions though:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/padStart
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/padEnd


Expected results:

We should update the code to use them.
(Assignee)

Updated

7 months ago
Component: General → Telemetry
Comment hidden (mozreview-request)
Thanks for the initiative.
I assigned it to you and gave you bug editing rights - you can assign the bug to yourself in the future.
Assignee: nobody → flyinggrub
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P4
Whiteboard: [measurement:client]

Comment 3

7 months ago
mozreview-review
Comment on attachment 8846671 [details]
Bug 1346812 - Use standard pad functions in aboutTelemetry.js

https://reviewboard.mozilla.org/r/119684/#review121548

This looks good, thanks.
Attachment #8846671 - Flags: review+

Comment 4

7 months ago
Pushed by georg.fritzsche@googlemail.com:
https://hg.mozilla.org/integration/autoland/rev/446bc40870fe
Use standard pad functions in aboutTelemetry.js r=gfritzsche
Backed out eslint failures (new temporary policy for autoland to not fix things with follow-up pushes):

https://hg.mozilla.org/integration/autoland/rev/d983cb91c5a48243adcd13187f4ae9f623f3d0d0

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=446bc40870fecc7ec49f1ae8b3aa6f6b2a62a56e&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://queue.taskcluster.net/v1/task/GTDPf6-ATDimiImrnchSJA/runs/0/artifacts/public/logs/live_backing.log

TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/toolkit/content/aboutTelemetry.js:178:34 | A space is required after ','. (comma-spacing) 

flyingrub, can you also add your email address to your hg identity, please? This makes it easier to e.g. track your checkins.
Flags: needinfo?(flyinggrub)
You can run eslint with e.g.: mach eslint toolkit/components/telemetry
Comment hidden (mozreview-request)
(Assignee)

Updated

7 months ago
Attachment #8846671 - Flags: review?(alessio.placitelli)
(Assignee)

Comment 8

7 months ago
It should be fixed. Thanks for the tip :gfritzsche :)
(Assignee)

Updated

7 months ago
Flags: needinfo?(flyinggrub)
Attachment #8846671 - Flags: review?(alessio.placitelli)
(Assignee)

Updated

7 months ago
Keywords: checkin-needed

Comment 9

7 months ago
mozreview-review
Comment on attachment 8846671 [details]
Bug 1346812 - Use standard pad functions in aboutTelemetry.js

https://reviewboard.mozilla.org/r/119684/#review122936
Attachment #8846671 - Flags: review+
Keywords: checkin-needed

Comment 10

7 months ago
Pushed by georg.fritzsche@googlemail.com:
https://hg.mozilla.org/integration/autoland/rev/a68031fd18af
Use standard pad functions in aboutTelemetry.js r=gfritzsche

Comment 11

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a68031fd18af
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Blocks: 1384534
You need to log in before you can comment on or make changes to this bug.