Closed
Bug 1346812
Opened 8 years ago
Closed 8 years ago
Use standard pad functions in aboutTelemetry.js
Categories
(Toolkit :: Telemetry, defect, P4)
Toolkit
Telemetry
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: flyingrub, Assigned: flyingrub)
References
Details
(Whiteboard: [measurement:client])
Attachments
(1 file)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170227084058
Steps to reproduce:
We use some custom padding code in aboutTelemetry.js:
https://dxr.mozilla.org/mozilla-central/search?q=path%3Atoolkit%2Fcontent%2FaboutTelemetry+pad+ext%3Ajs+ext%3Ajsm&redirect=false
Actual results:
JS now has standard padding functions though:
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/padStart
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/padEnd
Expected results:
We should update the code to use them.
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
Thanks for the initiative.
I assigned it to you and gave you bug editing rights - you can assign the bug to yourself in the future.
Assignee: nobody → flyinggrub
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P4
Whiteboard: [measurement:client]
Comment 3•8 years ago
|
||
mozreview-review |
Comment on attachment 8846671 [details]
Bug 1346812 - Use standard pad functions in aboutTelemetry.js
https://reviewboard.mozilla.org/r/119684/#review121548
This looks good, thanks.
Attachment #8846671 -
Flags: review+
Pushed by georg.fritzsche@googlemail.com:
https://hg.mozilla.org/integration/autoland/rev/446bc40870fe
Use standard pad functions in aboutTelemetry.js r=gfritzsche
Comment 5•8 years ago
|
||
Backed out eslint failures (new temporary policy for autoland to not fix things with follow-up pushes):
https://hg.mozilla.org/integration/autoland/rev/d983cb91c5a48243adcd13187f4ae9f623f3d0d0
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=446bc40870fecc7ec49f1ae8b3aa6f6b2a62a56e&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://queue.taskcluster.net/v1/task/GTDPf6-ATDimiImrnchSJA/runs/0/artifacts/public/logs/live_backing.log
TEST-UNEXPECTED-ERROR | /home/worker/checkouts/gecko/toolkit/content/aboutTelemetry.js:178:34 | A space is required after ','. (comma-spacing)
flyingrub, can you also add your email address to your hg identity, please? This makes it easier to e.g. track your checkins.
Flags: needinfo?(flyinggrub)
Comment 6•8 years ago
|
||
You can run eslint with e.g.: mach eslint toolkit/components/telemetry
Comment hidden (mozreview-request) |
Attachment #8846671 -
Flags: review?(alessio.placitelli)
Flags: needinfo?(flyinggrub)
Attachment #8846671 -
Flags: review?(alessio.placitelli)
Keywords: checkin-needed
Comment 9•8 years ago
|
||
mozreview-review |
Comment on attachment 8846671 [details]
Bug 1346812 - Use standard pad functions in aboutTelemetry.js
https://reviewboard.mozilla.org/r/119684/#review122936
Attachment #8846671 -
Flags: review+
Updated•8 years ago
|
Keywords: checkin-needed
Comment 10•8 years ago
|
||
Pushed by georg.fritzsche@googlemail.com:
https://hg.mozilla.org/integration/autoland/rev/a68031fd18af
Use standard pad functions in aboutTelemetry.js r=gfritzsche
Comment 11•8 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•