1346874 - Skip slower gray marking checks on Android

Status: RESOLVED FIXED

(Core :: JavaScript: GC, defect)

Description

[Steve Fink [:sfink] [:s:]]

It's looking to me like the Android debug slowdown is a little excessive, so at least for now, I'd like to disable the additional checks on that platform and configuration only.

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

this is valid

Comment 2

[Andrew McCreight [:mccr8]]

I think that makes sense. There shouldn't be much Android-specific code that interacts with gray marking.

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Skip gray mark check stack walk on DEBUG Android

oops, I never posted the patch for review.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/42720d7bd306
Skip gray mark check stack walk on DEBUG Android, r=mccr8

Comment 5

[Geoff Brown [:gbrown]]

sfink - Thanks very much for your efforts here. +1 for the strategy of checking less on Android...but are you sure it is working? I was expecting a dramatic savings, but the Android Debug job times look about the same before/after your push on inbound, and some of the timeouts that started with the gray marking seem to be persisting (there have only been a few pushes since yours, so it's early and hard to say, but a few of the timeout failures have happened already). Maybe the ifdef is wrong somehow? Maybe most of the time for gray marking is going somewhere else??

Comment 6

[Andrew McCreight [:mccr8]]

There's also the "run the GC over and over again!" checks that might be taking lots of time.

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/42720d7bd306

Comment 8

[Steve Fink [:sfink] [:s:]]

Needs more work.

Comment 9

[Joel Maher ( :jmaher ) (UTC -8)]

:sfink, sorry this fix didn't do the trick :(  Do you have another fix in the works that will land this week?  We are a couple weeks into some top intermittents and I would like to temporarily disable on Friday if we don't have something close to landing by then.

Comment 10

[Steve Fink [:sfink] [:s:]]

Attachment: Disable slow gray mark checks on Android

Moar Android test disabling.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b47db00299f4
Disable slow gray mark checks on Android, r=mccr8

Comment 12

[Steve Fink [:sfink] [:s:]]

(In reply to Joel Maher ( :jmaher) from comment #9)
> :sfink, sorry this fix didn't do the trick :(  Do you have another fix in
> the works that will land this week?  We are a couple weeks into some top
> intermittents and I would like to temporarily disable on Friday if we don't
> have something close to landing by then.

Yeah, I'm throwing in the towel and disabling bug 1335751 entirely on Android.

Comment 13

[Geoff Brown [:gbrown]]

First few Android test results on inbound are looking good now. Thanks Steve.

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b47db00299f4