Closed
Bug 1346967
Opened 7 years ago
Closed 7 years ago
Fix processing of ISimpleDOM IDL
Categories
(Core :: Disability Access APIs, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: bugzilla, Assigned: bugzilla)
Details
(Whiteboard: aes+)
Attachments
(1 file)
|
11.70 KB,
patch
|
tbsaunde
:
review+
|
Details | Diff | Splinter Review |
We're processing each IDL file separately, which means that the generated dlldata.c only references the last IDL that we processed. That means that only ISimpleDOMNode is being registered with COM; the other two interfaces are not. Also it means three MIDL invocations instead of one, which of course affects build times.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8846858 -
Flags: review?(tbsaunde+mozbugs)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8846858 [details] [diff] [review] Process all three ISimpleDOM IDL files in one MIDL pass ># HG changeset patch ># User Aaron Klotz <aklotz@mozilla.com> ># Date 1489444768 21600 ># Mon Mar 13 16:39:28 2017 -0600 ># Node ID e2d26b8ab792f66d3e0ec112aaa17a084b06acea ># Parent 7b19a63862252ffb89bfe1ba79724e76e20fb6f4 >Bug 1346967: Generate metadata for all three ISimpleDOM interfaces through via a single combined run of MIDL; r=tbsaunde the grammer there could use some work ;)
Attachment #8846858 -
Flags: review?(tbsaunde+mozbugs) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/0104334a6654e0c9601b6b4f7b58f085577fdc6a Bug 1346967: Generate metadata for all three ISimpleDOM interfaces via a single combined run of MIDL; r=tbsaunde
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/mozilla-inbound/rev/8087b31816d4 Generate metadata for all three ISimpleDOM interfaces via a single combined run of MIDL: CLOBBER. r=CLOBBER
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/0104334a6654 https://hg.mozilla.org/mozilla-central/rev/8087b31816d4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•