Fix processing of ISimpleDOM IDL

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: aklotz, Assigned: aklotz)

Tracking

Trunk
mozilla55
Unspecified
Windows
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: aes+)

Attachments

(1 attachment)

Assignee

Description

2 years ago
We're processing each IDL file separately, which means that the generated dlldata.c only references the last IDL that we processed.

That means that only ISimpleDOMNode is being registered with COM; the other two interfaces are not.

Also it means three MIDL invocations instead of one, which of course affects build times.
Comment on attachment 8846858 [details] [diff] [review]
Process all three ISimpleDOM IDL files in one MIDL pass

># HG changeset patch
># User Aaron Klotz <aklotz@mozilla.com>
># Date 1489444768 21600
>#      Mon Mar 13 16:39:28 2017 -0600
># Node ID e2d26b8ab792f66d3e0ec112aaa17a084b06acea
># Parent  7b19a63862252ffb89bfe1ba79724e76e20fb6f4
>Bug 1346967: Generate metadata for all three ISimpleDOM interfaces through via a single combined run of MIDL; r=tbsaunde

the grammer there could use some work ;)
Attachment #8846858 - Flags: review?(tbsaunde+mozbugs) → review+
Assignee

Comment 3

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0104334a6654e0c9601b6b4f7b58f085577fdc6a
Bug 1346967: Generate metadata for all three ISimpleDOM interfaces via a single combined run of MIDL; r=tbsaunde

Comment 4

2 years ago
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8087b31816d4
Generate metadata for all three ISimpleDOM interfaces via a single combined run of MIDL: CLOBBER. r=CLOBBER

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0104334a6654
https://hg.mozilla.org/mozilla-central/rev/8087b31816d4
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.