Closed
Bug 1346981
Opened 7 years ago
Closed 7 years ago
Add a Gecko Profiler label to WindowDestroyedEvent::Run
Categories
(Core :: DOM: Core & HTML, enhancement)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla55
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
Attachments
(1 file)
|
1.23 KB,
patch
|
nika
:
review+
|
Details | Diff | Splinter Review |
This function can potentially take a very long time. This label helps us identify it in BHR data via telemetry.
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8846863 -
Flags: review?(michael)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8846863 [details] [diff] [review] Add a Gecko Profiler label to WindowDestroyedEvent::Run Review of attachment 8846863 [details] [diff] [review]: ----------------------------------------------------------------- LGTM but why don't we label it outside of this if statement - the code looks like it probably won't be interesting out there, but it still seems odd to only label within the if statement.
Attachment #8846863 -
Flags: review?(michael) → review+
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/b9afc93ece6c Add a Gecko Profiler label to WindowDestroyedEvent::Run; r=mystor
|
||
Updated•7 years ago
|
Assignee: nobody → ehsan
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/b9afc93ece6c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•