Closed Bug 1347047 Opened 3 years ago Closed 3 years ago

Remove AccessibleCaret expiration feature in single caret mode

Categories

(Core :: Selection, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: TYLin, Assigned: bmo)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

The feature is controlled by "layout.accessiblecaret.timeout_ms" [1], and has been disable in bug 1268410.

[1] http://searchfox.org/mozilla-central/rev/a5c2b278897272497e14a8481513fee34bbc7e2c/modules/libpref/init/all.js#5292
Assignee: nobody → aschen
Status: NEW → ASSIGNED
Attachment #8847452 - Flags: review?(tlin)
Attachment #8847453 - Flags: review?(tlin)
Attachment #8847454 - Flags: review?(tlin)
Comment on attachment 8847452 [details]
Bug 1347047 Part 1 - Remove touch caret timeout test.

https://reviewboard.mozilla.org/r/120428/#review122980
Attachment #8847452 - Flags: review?(tlin) → review+
Comment on attachment 8847453 [details]
Bug 1347047 Part 2 - Remove caret timeout control from AccessibleCaretManager.

https://reviewboard.mozilla.org/r/120430/#review122982
Attachment #8847453 - Flags: review?(tlin) → review+
Comment on attachment 8847454 [details]
Bug 1347047 Part 3 - Remove pref layout.accessiblecaret.timeout_ms.

https://reviewboard.mozilla.org/r/120432/#review122984

Astley, thank you for working on this bug.
Attachment #8847454 - Flags: review?(tlin) → review+
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 9e6e3ed66846 -d b267bced06cc: rebasing 382394:9e6e3ed66846 "Bug 1347047 Part 1 - Remove touch caret timeout test. r=TYLin"
rebasing 382395:e21ec43418f7 "Bug 1347047 Part 2 - Remove caret timeout control from AccessibleCaretManager. r=TYLin"
merging layout/base/AccessibleCaretManager.cpp
merging layout/base/AccessibleCaretManager.h
warning: conflicts while merging layout/base/AccessibleCaretManager.cpp! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Comment on attachment 8847453 [details]
Bug 1347047 Part 2 - Remove caret timeout control from AccessibleCaretManager.

https://reviewboard.mozilla.org/r/120430/#review122988

::: layout/base/AccessibleCaretManager.h:131
(Diff revision 2)
>    enum class UpdateCaretsHint : uint8_t {
>      // Update everything including appearance and position.
>      Default,
>  
>      // Update everything while respecting the old appearance. For example, if
> -    // the caret in cursor mode is hidden due to timeout, do not change its
> +    // the caret in cursor mode is hidden, do not change its

Nit: s/due to timeout/due to blur/
Thanks for review.
Keywords: checkin-needed
Pushed by tlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4503ff6c5820
Part 1 - Remove touch caret timeout test. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/7d31847c1d11
Part 2 - Remove caret timeout control from AccessibleCaretManager. r=TYLin
https://hg.mozilla.org/integration/autoland/rev/867cf8e067a7
Part 3 - Remove pref layout.accessiblecaret.timeout_ms. r=TYLin
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/4503ff6c5820
https://hg.mozilla.org/mozilla-central/rev/7d31847c1d11
https://hg.mozilla.org/mozilla-central/rev/867cf8e067a7
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.