Closed Bug 1347060 Opened 3 years ago Closed 1 year ago

Remove marionette test for rotatable devices

Categories

(Core :: DOM: Selection, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: TYLin, Assigned: manishkk)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

need to remove only these 2 lines or anything else?


(In reply to Ting-Yu Lin [:TYLin] (UTC+8) (Away, use ni? please) from comment #0)
> Specifically, test_caret_position_after_changing_orientation_of_device() [1].
> 
> [1]
> http://searchfox.org/mozilla-central/rev/
> a5c2b278897272497e14a8481513fee34bbc7e2c/layout/base/tests/marionette/
> test_accessiblecaret_selection_mode.py#502-503
Flags: needinfo?(aethanyc)
Assignee: nobody → 1991manish.kumar
Attached patch Patch_Bug1347060Splinter Review
Please review!
Attachment #9005492 - Flags: review?(aethanyc)
Comment on attachment 9005492 [details] [diff] [review]
Patch_Bug1347060

Review of attachment 9005492 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks!
Attachment #9005492 - Flags: review?(aethanyc) → review+
Whiteboard: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea2402bdef40
Remove marionette test for rotatable devices r=TYLin
Whiteboard: checkin-needed
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab32c7bf37a4
Remove marionette test for rotatable devices r=TYLin
Relanded due to https://hg.mozilla.org/mozilla-central/rev/6c83f735355d being merged into inbound.
https://hg.mozilla.org/mozilla-central/rev/ab32c7bf37a4
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Flags: qe-verify-
You need to log in before you can comment on or make changes to this bug.