1347060 - Remove marionette test for rotatable devices

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement)

Description

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Specifically, test_caret_position_after_changing_orientation_of_device() [1].

[1] http://searchfox.org/mozilla-central/rev/a5c2b278897272497e14a8481513fee34bbc7e2c/layout/base/tests/marionette/test_accessiblecaret_selection_mode.py#502-503

Comment 1

[Manish [:manishkk]]

need to remove only these 2 lines or anything else?


(In reply to Ting-Yu Lin [:TYLin] (UTC+8) (Away, use ni? please) from comment #0)
> Specifically, test_caret_position_after_changing_orientation_of_device() [1].
> 
> [1]
> http://searchfox.org/mozilla-central/rev/
> a5c2b278897272497e14a8481513fee34bbc7e2c/layout/base/tests/marionette/
> test_accessiblecaret_selection_mode.py#502-503

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Not only these two lines, but the entire functions.  

https://dxr.mozilla.org/mozilla-central/rev/0ceabd10aac2272e83850e278c7876f32dbae42e/layout/base/tests/marionette/test_accessiblecaret_selection_mode.py#498-524

Comment 3

[Manish [:manishkk]]

Attachment: Patch_Bug1347060

Please review!

Comment 4

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 9005492 [details] [diff] [review]
Patch_Bug1347060

Review of attachment 9005492 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me. Thanks!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea2402bdef40
Remove marionette test for rotatable devices r=TYLin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ab32c7bf37a4
Remove marionette test for rotatable devices r=TYLin

Comment 7

[Andreea Pavel [:apavel]]

Relanded due to https://hg.mozilla.org/mozilla-central/rev/6c83f735355d being merged into inbound.

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ab32c7bf37a4