1347089 - [e10s] Background on <select> options is transparent

Status: RESOLVED FIXED

(Core :: Layout: Form Controls, defect)

Description

[blinky]

Steps to reproduce:

1. Go to https://onedrive.live.com/download?cid=F96BA52A2AF70D03&resid=F96BA52A2AF70D03%21333&authkey=AOmQDs9Gueybv98.
2. Open the <select> element.


Actual results:

The background is transparent.

Screenshot https://1drv.ms/i/s!AgMN9yoqpWv5glCJmtBMNd_P-O3C

Comment 1

[blinky]

Regression range:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9da1857374780d5fc4c8babf11bf2d1ac8443bd4&tochange=4dafc922f1cbfef52fbd736f6b6cb5c15d9bd3f1

Regressed by: bug 1336301

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

This simplified URL also reproduces the issue. It looks like Chrome is ignoring the alpha channel on the background color, whereas we are currently using the supplied alpha channel. I guess we should ignore it too.

data:text/html,<select style="background-color: rgba(255,255,255,.55); color: black"><option>one<option>two<option>three</select><br/>hi mom

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

I should be able to put a patch up for this today.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

[Tracking Requested - why for this release]: Visible UI regression in content related to bug 910022

Comment 5

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1347089 - Force translucent and transparent select backgroundColors to opaque to match parity with other browsers.

Previously we were respecting the webpages request to show a translucent background on popups, though it now seems that content didn't actually
want a translucent background. After comparing with Chrome, I see that they remove the alpha channel and always show the background color as
fully opaque. This patch also fixes a related bug where the background-color may have been set to a transparent color (not rgba(0, 0, 0, 0)) and
we would show the popup as transparent. This is now fixed with this patch as well.

Review commit: https://reviewboard.mozilla.org/r/120230/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120230/

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1347089 - Consolidate some of the testing functions to remove duplication.

Review commit: https://reviewboard.mozilla.org/r/120234/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120234/

Comment 7

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8847228 [details]
Bug 1347089 - Consolidate some of the testing functions to remove duplication.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/120234/diff/1-2/

Comment 8

[Julien Cristau [:jcristau]]

Tracking as ui regression in 54.

Comment 9

[Dave Townsend [:mossop]]

Comment on attachment 8847223 [details]
Bug 1347089 - Force translucent and transparent select backgroundColors to opaque to match parity with other browsers.

https://reviewboard.mozilla.org/r/120230/#review122600

Comment 10

[Dave Townsend [:mossop]]

Comment on attachment 8847228 [details]
Bug 1347089 - Consolidate some of the testing functions to remove duplication.

https://reviewboard.mozilla.org/r/120234/#review122602

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e19be80e0e0
Force translucent and transparent select backgroundColors to opaque to match parity with other browsers. r=mossop
https://hg.mozilla.org/integration/autoland/rev/2cac3caad0fa
Consolidate some of the testing functions to remove duplication. r=mossop

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3e19be80e0e0
https://hg.mozilla.org/mozilla-central/rev/2cac3caad0fa

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8847223 [details]
Bug 1347089 - Force translucent and transparent select backgroundColors to opaque to match parity with other browsers.

Approval Request Comment
[Feature/Bug causing the regression]: regression from bug 910022
[User impact if declined]: some select menus may be transparent depending on how the webpage is set up
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: no
[Why is the change risky/not risky?]: contained fix to the <select> menus when they may have an alpha channel defined
[String changes made/needed]: none

Comment 14

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8847228 [details]
Bug 1347089 - Consolidate some of the testing functions to remove duplication.

See comment #13.

Comment 15

[Gerry Chang [:gchang]]

Comment on attachment 8847223 [details]
Bug 1347089 - Force translucent and transparent select backgroundColors to opaque to match parity with other browsers.

Fix an UI regression related to select menus. Aurora54+.

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/cfa5921c7384
https://hg.mozilla.org/releases/mozilla-aurora/rev/4fb9f172ec9d