Closed Bug 1347089 Opened 8 years ago Closed 8 years ago

[e10s] Background on <select> options is transparent

Categories

(Core :: Layout: Form Controls, defect)

Product:
Core
Component:
Layout: Form Controls
Version:
55 Branch
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox52 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 + fixed
firefox55 --- fixed

People

(Reporter: over68, Assigned: jaws)

References

(
URL
)

Details

(Keywords: regression, Whiteboard: [uplift note: this patch must be applied after the patches from bug 1346440])

Attachments

(2 files)

Bug 1347089 - Force translucent and transparent select backgroundColors to opaque to match parity with other browsers.
59 bytes, text/x-review-board-request
mossop
: review+
gchang
: approval-mozilla-aurora+
Details
Bug 1347089 - Consolidate some of the testing functions to remove duplication.
59 bytes, text/x-review-board-request
mossop
: review+
gchang
: approval-mozilla-aurora+
Details
Steps to reproduce: 1. Go to https://onedrive.live.com/download?cid=F96BA52A2AF70D03&resid=F96BA52A2AF70D03%21333&authkey=AOmQDs9Gueybv98. 2. Open the <select> element. Actual results: The background is transparent. Screenshot https://1drv.ms/i/s!AgMN9yoqpWv5glCJmtBMNd_P-O3C
Flags: needinfo?(jaws)
This simplified URL also reproduces the issue. It looks like Chrome is ignoring the alpha channel on the background color, whereas we are currently using the supplied alpha channel. I guess we should ignore it too. data:text/html,<select style="background-color: rgba(255,255,255,.55); color: black"><option>one<option>two<option>three</select><br/>hi mom
URL: data:text/html,<select style="backgro...
Flags: needinfo?(jaws)
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(jaws)
I should be able to put a patch up for this today.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Flags: needinfo?(jaws)
[Tracking Requested - why for this release]: Visible UI regression in content related to bug 910022
status-firefox53: --- → ?
status-firefox54: --- → affected
status-firefox55: --- → affected
tracking-firefox54: --- → ?
Tracking as ui regression in 54.
tracking-firefox54: ? → +
Attachment #8847223 - Flags: review?(mconley) → review?(dtownsend)
Attachment #8847228 - Flags: review?(mconley) → review?(dtownsend)
Comment on attachment 8847223 [details] Bug 1347089 - Force translucent and transparent select backgroundColors to opaque to match parity with other browsers. https://reviewboard.mozilla.org/r/120230/#review122600
Attachment #8847223 - Flags: review?(dtownsend) → review+
Comment on attachment 8847228 [details] Bug 1347089 - Consolidate some of the testing functions to remove duplication. https://reviewboard.mozilla.org/r/120234/#review122602
Attachment #8847228 - Flags: review?(dtownsend) → review+
Pushed by jwein@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3e19be80e0e0 Force translucent and transparent select backgroundColors to opaque to match parity with other browsers. r=mossop https://hg.mozilla.org/integration/autoland/rev/2cac3caad0fa Consolidate some of the testing functions to remove duplication. r=mossop
https://hg.mozilla.org/mozilla-central/rev/3e19be80e0e0 https://hg.mozilla.org/mozilla-central/rev/2cac3caad0fa
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment on attachment 8847223 [details] Bug 1347089 - Force translucent and transparent select backgroundColors to opaque to match parity with other browsers. Approval Request Comment [Feature/Bug causing the regression]: regression from bug 910022 [User impact if declined]: some select menus may be transparent depending on how the webpage is set up [Is this code covered by automated tests?]: yes [Has the fix been verified in Nightly?]: no [Needs manual test from QE? If yes, steps to reproduce]: no [List of other uplifts needed for the feature/fix]: none [Is the change risky?]: no [Why is the change risky/not risky?]: contained fix to the <select> menus when they may have an alpha channel defined [String changes made/needed]: none
Attachment #8847223 - Flags: approval-mozilla-aurora?
Comment on attachment 8847228 [details] Bug 1347089 - Consolidate some of the testing functions to remove duplication. See comment #13.
Attachment #8847228 - Flags: approval-mozilla-aurora?
Whiteboard: [uplift note: this patch must be applied after the patches from bug 1346440]
Comment on attachment 8847223 [details] Bug 1347089 - Force translucent and transparent select backgroundColors to opaque to match parity with other browsers. Fix an UI regression related to select menus. Aurora54+.
Attachment #8847223 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Attachment #8847228 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: