1347186 - Add mochitest-browser-chrome to test adding and updating profiles from editProfile dialog

Status: RESOLVED FIXED

(Toolkit :: Form Manager, enhancement, P3)

Description

[Scott Wu [:scottwu]]

Add tests to cover adding and updating form autofill profiles using the editProfile dialog in preferences (bug 1019471).

Comment 1

[Scott Wu [:scottwu]]

Attachment: Bug 1347186 - (Part 2) Add mochitest-browser-chrome test for Form Autofill edit profile dialog.

Review commit: https://reviewboard.mozilla.org/r/122700/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122700/

Comment 2

[Scott Wu [:scottwu]]

Attachment: Bug 1347186 - (Part 1) Move common utility functions to head.js.

Review commit: https://reviewboard.mozilla.org/r/133278/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/133278/

Comment 3

[Scott Wu [:scottwu]]

Comment on attachment 8849943 [details]
Bug 1347186 - (Part 2) Add mochitest-browser-chrome test for Form Autofill edit profile dialog.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122700/diff/1-2/

Comment 4

[Scott Wu [:scottwu]]

Comment on attachment 8861305 [details]
Bug 1347186 - (Part 1) Move common utility functions to head.js.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/133278/diff/1-2/

Comment 5

[Scott Wu [:scottwu]]

Comment on attachment 8849943 [details]
Bug 1347186 - (Part 2) Add mochitest-browser-chrome test for Form Autofill edit profile dialog.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/122700/diff/2-3/

Comment 6

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8861305 [details]
Bug 1347186 - (Part 1) Move common utility functions to head.js.

https://reviewboard.mozilla.org/r/133278/#review139542

Comment 7

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8849943 [details]
Bug 1347186 - (Part 2) Add mochitest-browser-chrome test for Form Autofill edit profile dialog.

https://reviewboard.mozilla.org/r/122700/#review139550

Overall it looks good. Thanks.

Comment 8

[Scott Wu [:scottwu]]

Thanks Luke! Checking it in.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58d9543c13dc
(Part 1) Move common utility functions to head.js. r=lchang
https://hg.mozilla.org/integration/autoland/rev/f7c747dfd01a
(Part 2) Add mochitest-browser-chrome test for Form Autofill edit profile dialog. r=lchang

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/58d9543c13dc
https://hg.mozilla.org/mozilla-central/rev/f7c747dfd01a