1347273 - stylo: Media query parsing is bogus.

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Emilio Cobos Álvarez [:emilio]]

While I was looking at other tests that fail after bug 1328652, some of the failures are in Servo's media-query parsing.

The following test case fails in stylo:

<style>
@media not all and (bogus), all {
  #test { color: green; }
}
</style>
<p id="test">Passes if this text is green</p>

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1347273: Test expectation adjustments.

Review commit: https://reviewboard.mozilla.org/r/120270/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120270/

Comment 2

[Emilio Cobos Álvarez [:emilio]]

The previous patch makes us pass all the tests under layout/style/test/test_acid3_test46.html.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Upstream patch

Submitted upstream for faster landing times when needed.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1347273: Test expectation adjustments.

Review commit: https://reviewboard.mozilla.org/r/120312/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120312/

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8847257 [details]
Bug 1347273: Test expectation adjustments.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/120270/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c017ec8e88c1
Test expectation adjustments. r=emilio

Comment 7

[Cameron McCormack (:heycam)]

Comment on attachment 8847319 [details]
Bug 1347273: Test expectation adjustments.

https://reviewboard.mozilla.org/r/120312/#review122924

Comment 8

[Cameron McCormack (:heycam)]

Comment on attachment 8847257 [details]
Bug 1347273: Test expectation adjustments.

https://reviewboard.mozilla.org/r/120270/#review122926

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c017ec8e88c1