Closed Bug 1347367 Opened 3 years ago Closed 3 years ago

Remove FindUserSelectAllNode

Categories

(Core :: Editor, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: m_kato, Unassigned)

Details

Attachments

(1 file)

After bug 769967, FindUserSelectAllNode returns nullptr only.  But some still calls it (http://searchfox.org/mozilla-central/search?q=FindUserSelectAllNode&case=false&regexp=false&path=)
Comment on attachment 8847459 [details]
Bug 1347367 - Remove unimplemented FindUserSelectAllNode.

https://reviewboard.mozilla.org/r/120436/#review122430

Hmm, indeed, this does not change any behavior of current editor. However, I'm afraid that this might include a hit to fix non-reported bugs (regressions of bug 769967), though.
Attachment #8847459 - Flags: review?(masayuki) → review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/autoland/rev/a84020dbffc0
Remove unimplemented FindUserSelectAllNode. r=masayuki
https://hg.mozilla.org/mozilla-central/rev/a84020dbffc0
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.