1347367 - Remove FindUserSelectAllNode

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement)

Description

[Makoto Kato [:m_kato]]

After bug 769967, FindUserSelectAllNode returns nullptr only.  But some still calls it (http://searchfox.org/mozilla-central/search?q=FindUserSelectAllNode&case=false&regexp=false&path=)

Comment 1

[Makoto Kato [:m_kato]]

Attachment: Bug 1347367 - Remove unimplemented FindUserSelectAllNode.

After bug 769967, FindUserSelectAllNode always returns nullptr.  So we get rid of this method.  Also, AreaRestriction is used by this, so it is unnecessary now.

Review commit: https://reviewboard.mozilla.org/r/120436/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120436/

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8847459 [details]
Bug 1347367 - Remove unimplemented FindUserSelectAllNode.

https://reviewboard.mozilla.org/r/120436/#review122430

Hmm, indeed, this does not change any behavior of current editor. However, I'm afraid that this might include a hit to fix non-reported bugs (regressions of bug 769967), though.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a84020dbffc0
Remove unimplemented FindUserSelectAllNode. r=masayuki

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a84020dbffc0