1347379 - nsLoadGroup::Init() can be too slow

Status: RESOLVED FIXED

(Core :: Networking, enhancement)

Description

[(no longer active)]

See this profile: <https://perfht.ml/2nqIqGw>

10ms of time spent searching this hashtable: <http://searchfox.org/mozilla-central/rev/ca7015fa45b30b29176fbaa70ba0a36fe9263c38/netwerk/base/RequestContextService.cpp#174>

This is stupid, because we have *just* created a UUID <http://searchfox.org/mozilla-central/rev/ca7015fa45b30b29176fbaa70ba0a36fe9263c38/netwerk/base/nsLoadGroup.cpp#1076>, so this search will always fail, and any time spent here is guaranteed wasted time, period.  :(

Comment 1

[(no longer active)]

Attachment: Don't bother searching for a newly generated UUID in the request context hashtable

Comment 2

[Patrick McManus [:mcmanus]]

Comment on attachment 8847414 [details] [diff] [review]
Don't bother searching for a newly generated UUID in the request context hashtable

Review of attachment 8847414 [details] [diff] [review]:
-----------------------------------------------------------------

thanks.

10ms seems a little weird tho.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f53b9b2d22a
Don't bother searching for a newly generated UUID in the request context hashtable; r=mcmanus

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5f53b9b2d22a