Closed
Bug 1347379
Opened 7 years ago
Closed 7 years ago
nsLoadGroup::Init() can be too slow
Categories
(Core :: Networking, enhancement)
Core
Networking
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox55 | --- | fixed |
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
Details
Attachments
(1 file)
|
3.42 KB,
patch
|
mcmanus
:
review+
|
Details | Diff | Splinter Review |
See this profile: <https://perfht.ml/2nqIqGw> 10ms of time spent searching this hashtable: <http://searchfox.org/mozilla-central/rev/ca7015fa45b30b29176fbaa70ba0a36fe9263c38/netwerk/base/RequestContextService.cpp#174> This is stupid, because we have *just* created a UUID <http://searchfox.org/mozilla-central/rev/ca7015fa45b30b29176fbaa70ba0a36fe9263c38/netwerk/base/nsLoadGroup.cpp#1076>, so this search will always fail, and any time spent here is guaranteed wasted time, period. :(
|
Assignee | |
Comment 1•7 years ago
|
||
Attachment #8847414 -
Flags: review?(mcmanus)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8847414 [details] [diff] [review] Don't bother searching for a newly generated UUID in the request context hashtable Review of attachment 8847414 [details] [diff] [review]: ----------------------------------------------------------------- thanks. 10ms seems a little weird tho.
Attachment #8847414 -
Flags: review?(mcmanus) → review+
|
||
Updated•7 years ago
|
Whiteboard: [qf:p1]
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5f53b9b2d22a Don't bother searching for a newly generated UUID in the request context hashtable; r=mcmanus
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/5f53b9b2d22a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
|
||
Updated•2 years ago
|
Performance Impact: --- → P1
Whiteboard: [qf:p1]
You need to log in
before you can comment on or make changes to this bug.
Description
•