1347394 - Eclipse project files for JSS

Status: RESOLVED FIXED

(JSS Graveyard :: Library, defect)

Description

[Endi S. Dewata]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0
Build ID: 20170125094131

Steps to reproduce:

To simplify and standardize JSS development the Eclipse project file, classpath, settings should be included in the source repository.


Actual results:

Currently JSS developers would need to create their own Eclipse project and manually configure the classpath. The projects might be configured differently causing inconsistencies (e.g. tabs vs spaces for indentation).


Expected results:

The Eclipse project files should be included in the source repository such that anybody can simply add it to their Eclipse workspace.

Comment 1

[Endi S. Dewata]

Attachment: 0001-Added-Eclipse-project-files.patch

Eclipse project file, classpath, settings have been added to
automate cleanups and certain formattings which will simplify and
standardize the development.

Comment 2

[Endi S. Dewata]

Attachment: 0002-Cleaned-up-SSLSocket-class.patch

The SSLSocket class has been cleaned up using Eclipse to remove
trailing white spaces and wildcards in import statements.

Comment 3

[Elio Maldonado]

Comment on attachment 8848654 [details] [diff] [review]
0001-Added-Eclipse-project-files.patch

Review of attachment 8848654 [details] [diff] [review]:
-----------------------------------------------------------------

r+, Applies cleanly and no extra warnings on the build, ran test and all pass.

Comment 4

[Elio Maldonado]

Comment on attachment 8848655 [details] [diff] [review]
0002-Cleaned-up-SSLSocket-class.patch

Review of attachment 8848655 [details] [diff] [review]:
-----------------------------------------------------------------

r+, Applies cleanly and no extra warnings on the build, ran test and all pass.

Comment 5

[Elio Maldonado]

I should add that it would be nice to document how to build and test with Mercurial and possible in a platform agnostic manner but that can wait to a follow-up separate bug for a later time.

Comment 6

[Elio Maldonado]

Pushed:
https://hg.mozilla.org/projects/jss/rev/ea54f0555d0d0bd571af227bbb847cf0c0cb641e
https://hg.mozilla.org/projects/jss/rev/7184079cfbf3727cf95a00df5095ae4ca7a2c913
https://hg.mozilla.org/projects/jss/rev/2a57326753132be7bd5c5d3a8c23073894aa23b0
https://hg.mozilla.org/projects/jss/rev/73d4029d986bff42a0f4dd31eb774b0bca0f9270