1347426 - Implement section-* for autocomplete attribute

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Description

[John Dai[:jdai]]

as specified: https://html.spec.whatwg.org/multipage/forms.html#attr-fe-autocomplete-section

Comment 1

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Hi John, thanks for bug 1340477 comment 3 and filing this. Please also help with this! :)

Hi Vance, due to the Dawn project, any changes to the expected timeframe for this bug? Or it remains targeting by June 12?

Comment 2

[Hsin-Yi Tsai (she/her)[:hsinyi]]

Had meeting with Vance last week, it's fine for clearing the NI for the schedule question.

Comment 3

[John Dai[:jdai]]

Attachment: patch, v1

- Support section-* can be parsed by autocomplete attribute.
- Update test_autocompleteinfo.html and test_input_autocomplete.html accordingly.

The optional section-* field is showed by 
1) Two tokens, (section-* field[1])
2) Three tokens, (section-* mode[2] field), (section-* contact[3] tel_field)
3) Four tokens, (section-* mode contact tel_field)

[1] https://html.spec.whatwg.org/#autofill-detail-tokens
[2] mode means shipping or billing.
[3] contact means home, work, mobile, fax, and page.

Hi Olli, 
I saw parsing autocomplete attribute was reviewed by you. Could you help to review this patch? Thank you.  

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=06d1c651044c924a2f0e2a3447c5866c42b5623e&filter-tier=1&group_state=expanded

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Do other browsers supports section-*?

Comment 5

[John Dai[:jdai]]

(In reply to Olli Pettay [:smaug] from comment #4)
> Do other browsers supports section-*?

Safari 10.0.3 support section-*. Chromium and Edge don't do proper token splitting in the processing model[1]. They just return what you set in autocomplete attribute. 


[1] https://html.spec.whatwg.org/multipage/forms.html#autofill-processing-model

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8859456 [details] [diff] [review]
patch, v1

Please add more tests for invalid values.
Like cases when tokens are in random order, or when there are tokens like
secti or so.

Comment 7

[John Dai[:jdai]]

Attachment: patch, v2

Address comment #2, which is adding more tests for invalid values.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=367a72205caef3e731e1ab33b195c931f707e606&group_state=expanded&filter-tier=1

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6efbe0c856e3
Implement section-* for autocomplete attribute. r=smaug

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6efbe0c856e3

Comment 10

[Adrian Florinescu [:aflorinescu]]

As per San-Francisco meeting with :vchen, marking this bug as qe-.