Closed
Bug 1347470
Opened 7 years ago
Closed 7 years ago
wrong content length for a 200 which overwrites cache with alt data
Categories
(Core :: Networking: Cache, enhancement)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: CuveeHsu, Assigned: CuveeHsu)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file, 1 obsolete file)
3.62 KB,
patch
|
valentin
:
review+
|
Details | Diff | Splinter Review |
Since content length depends on |mAvailableCachedAltDataType| [1], we should clean the status after if we don't pass revalidation and get an update content. [1] http://searchfox.org/mozilla-central/rev/ca7015fa45b30b29176fbaa70ba0a36fe9263c38/netwerk/protocol/http/HttpBaseChannel.cpp#705
Assignee | ||
Comment 1•7 years ago
|
||
Attachment #8847519 -
Flags: review?(michal.novotny)
Comment 2•7 years ago
|
||
I'd prefer to put resetting mAvailableCachedAltDataType to InitCacheEntry(). The other option is to move setting mAvailableCachedAltDataType to OnStartRequest(). Valentin, what's your opinion?
Flags: needinfo?(valentin.gosu)
Updated•7 years ago
|
Attachment #8847519 -
Flags: review?(michal.novotny)
Comment 3•7 years ago
|
||
(In reply to Michal Novotny (:michal) from comment #2) > I'd prefer to put resetting mAvailableCachedAltDataType to InitCacheEntry(). > The other option is to move setting mAvailableCachedAltDataType to > OnStartRequest(). Valentin, what's your opinion? I agree, InitCacheEntry seems like the better choice.
Flags: needinfo?(valentin.gosu)
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8847519 -
Attachment is obsolete: true
Attachment #8847872 -
Flags: review?(valentin.gosu)
Updated•7 years ago
|
Attachment #8847872 -
Flags: review?(valentin.gosu) → review+
Assignee | ||
Comment 5•7 years ago
|
||
wait for the treeherder green https://treeherder.mozilla.org/#/jobs?repo=try&revision=3fa647338c34200727b07cdc683c3e13ce6dd39a
Assignee | ||
Comment 6•7 years ago
|
||
Bug 1334388 is fixed. I guess the orange will disappear after rebase.
Assignee | ||
Comment 7•7 years ago
|
||
confirm comment 6 https://treeherder.mozilla.org/#/jobs?repo=try&revision=f22ab7bc690ca5f8dcad44e3b7e3e70e743cd1a4
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2fd89162ba8d clean mAvailableCachedAltDataType when we get 200, r=valentin
Keywords: checkin-needed
Comment 9•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/2fd89162ba8d
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•