1347470 - wrong content length for a 200 which overwrites cache with alt data

Status: RESOLVED FIXED

(Core :: Networking: Cache, enhancement)

Description

[Junior [inactive]]

Since content length depends on |mAvailableCachedAltDataType| [1], we should clean the status after if we don't pass revalidation and get an update content.

[1] http://searchfox.org/mozilla-central/rev/ca7015fa45b30b29176fbaa70ba0a36fe9263c38/netwerk/protocol/http/HttpBaseChannel.cpp#705

Comment 1

[Junior [inactive]]

Attachment: cleanAltType

Comment 2

[Michal Novotny [:michal]]

I'd prefer to put resetting mAvailableCachedAltDataType to InitCacheEntry(). The other option is to move setting mAvailableCachedAltDataType to OnStartRequest(). Valentin, what's your opinion?

Comment 3

[Valentin Gosu [:valentin]]

(In reply to Michal Novotny (:michal) from comment #2)
> I'd prefer to put resetting mAvailableCachedAltDataType to InitCacheEntry().
> The other option is to move setting mAvailableCachedAltDataType to
> OnStartRequest(). Valentin, what's your opinion?

I agree, InitCacheEntry seems like the better choice.

Comment 4

[Junior [inactive]]

Attachment: cleanAltType - v2

Comment 5

[Junior [inactive]]

wait for the treeherder green
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3fa647338c34200727b07cdc683c3e13ce6dd39a

Comment 6

[Junior [inactive]]

Bug 1334388 is fixed. I guess the orange will disappear after rebase.

Comment 7

[Junior [inactive]]

confirm comment 6
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f22ab7bc690ca5f8dcad44e3b7e3e70e743cd1a4

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2fd89162ba8d
clean mAvailableCachedAltDataType when we get 200, r=valentin

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/2fd89162ba8d