1347552 - Add telemetry for the Layout panel

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

Since this is a new panel, we need to add telemetry for it.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1347552 - Add telemetry for the Layout Panel.

Review commit: https://reviewboard.mozilla.org/r/121944/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121944/

Comment 2

[Patrick Brosset <:pbro>]

Comment on attachment 8849112 [details]
Bug 1347552 - Add telemetry for the Layout Panel.

Sole, do you mind reviewing this change? I feel like your knowledge of telemetry is fresher than mine. Also, does this need an extra review for the new histogram?

Comment 3

[Soledad Penades [:sole] [:spenades]]

Sure!

Question for Gabriel: are you calling toolOpened anywhere? It looks from the diff that you added the histograms, but you didn't use them?

If you look at the instructions in https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/telemetry.js#27 it mentions this bit.

Also yes, you will need to request a data-review "feedback" flag as I did on this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1343501#c8 - possibly also flag Bryan so he commits to using the data, otherwise the data group will not be happy about a "expires=never" histogram.

To catch potential errors on the Histograms.json which you modified, instead of repeatedly pushing to try, you can build locally (not using artifact builds or ./mach build faster). Otherwise the 'faster' building processes don't use the same Python script that is used to validate the json file. Save time now by compiling now instead of letting try tell you :)

Comment 4

[Gabriel Luong [:gl] (ΦωΦ)]

(In reply to Soledad Penades [:sole] [:spenades] from comment #3)
> Sure!
> 
> Question for Gabriel: are you calling toolOpened anywhere? It looks from the
> diff that you added the histograms, but you didn't use them?
> 
> If you look at the instructions in
> https://dxr.mozilla.org/mozilla-central/source/devtools/client/shared/
> telemetry.js#27 it mentions this bit.
> 

Yes, this is done automatically in client/inspector/toolsidebar.js which is used to build the sidebars in the inspector.

> Also yes, you will need to request a data-review "feedback" flag as I did on
> this bug https://bugzilla.mozilla.org/show_bug.cgi?id=1343501#c8 - possibly
> also flag Bryan so he commits to using the data, otherwise the data group
> will not be happy about a "expires=never" histogram.
> 
> To catch potential errors on the Histograms.json which you modified, instead
> of repeatedly pushing to try, you can build locally (not using artifact
> builds or ./mach build faster). Otherwise the 'faster' building processes
> don't use the same Python script that is used to validate the json file.
> Save time now by compiling now instead of letting try tell you :)

Comment 5

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8849112 [details]
Bug 1347552 - Add telemetry for the Layout Panel.

Needinfo'ing clarkbw for data commit
Data feedback from smedbergs

Comment 6

[Soledad Penades [:sole] [:spenades]]

Comment on attachment 8849112 [details]
Bug 1347552 - Add telemetry for the Layout Panel.

https://reviewboard.mozilla.org/r/121944/#review124396

If you're calling toolOpened, then it looks good to me.

Comment 7

[Benjamin Smedberg]

Comment on attachment 8849112 [details]
Bug 1347552 - Add telemetry for the Layout Panel.

https://reviewboard.mozilla.org/r/121944/#review124532

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/f12551f0027b
Add telemetry for the Layout panel. r=sole, bsmedberg

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5656cc1c90f3
Part 2: Added missing alert_emails and bug_numbers fields to DEVTOOLS_LAYOUTVIEW_TIME_ACTIVE_SECONDS telemetry. r=me

Comment 10

[Bryan Clark (DevTools PM) [:clarkbw]]

Adding this to the Inspector panels query.  Thanks!

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f12551f0027b
https://hg.mozilla.org/mozilla-central/rev/5656cc1c90f3