1347569 - Decision Task for Nightly Desktop + Android failed with KeyError: u'NS7jKig_R8-1F_7DWSTQ-Q'

Status: RESOLVED FIXED

(Taskcluster :: General, defect)

Description

[Carsten Book [:Tomcat]]

https://treeherder.mozilla.org/logviewer.html#?job_id=83974842&repo=mozilla-central

likely regression from Bug 1333255

Affecting Nightly Builds (note that we need to retrigger them when this is fixed) so marking as blocker

Comment 1

[Dustin J. Mitchell [:dustin] (he/him)]

Attachment: Bug 1347569: don't add optmized tasks to task.dependencies;

`task.dependencies` is part of the internal taskgraph calculations, so it must
only refer to tasks that are being created, and not to those which already
exist.  `task.task['dependencies']`, on the other hand, is what is given to
`queue.createTask` and expresses all dependencies.

Review commit: https://reviewboard.mozilla.org/r/120584/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120584/

Comment 2

[Dustin J. Mitchell [:dustin] (he/him)]

I was unable to reproduce this, due to bug 1347582, so I'm hoping this fixes the issue!

Comment 3

[Justin Wood (:Callek)]

Comment on attachment 8847640 [details]
Bug 1347569: don't add optmized tasks to task.dependencies;

https://reviewboard.mozilla.org/r/120584/#review122528

This looks like it will fix the issue, I have concerns over the ambiguity of *.dependency style stuff here and how they all differ... but I know you also have concerns there.

Comment 4

[Dustin J. Mitchell [:dustin] (he/him)]

Yeah, turns out fixing that dependency stuff was a big ball of wax that I elected not to tackle (since the beetmover* kinds examine dependencies of dependencies)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/742130b3c124
don't add optmized tasks to task.dependencies; r=Callek

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/742130b3c124