Closed Bug 1347625 Opened 4 years ago Closed 3 years ago

Assertion failure: [GFX1]: Texture deallocated too late during shutdown, at gfx/2d/Logging.h:518

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

54 Branch
defect

Tracking

()

RESOLVED FIXED
Tracking Status
firefox52 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- disabled
firefox55 --- disabled

People

(Reporter: florian, Assigned: jmaher)

References

(Blocks 1 open bug)

Details

(Keywords: assertion, intermittent-failure, memory-leak, Whiteboard: [stockwell fixed:product])

Attachments

(1 file)

See failures in https://treeherder.mozilla.org/#/jobs?repo=try&revision=b9b278db557d on the new browser_devices_get_user_media_multi_process.js test.

I'm going to have to disable it for "e10s && debug" to land bug 1325049.
From the following, VideoDevice, MediaDevice, and MediaEngineRemoteVideoSource were destroyed too late during ShutdownXPCOM. Then I don't think it is a gfx bug.
  https://treeherder.mozilla.org/logviewer.html#?job_id=84021642&repo=try&lineNumber=3178
:jesup, can you comment to the bug?
Flags: needinfo?(rjesup)
hmmm, we've had issues like this in the past.  Something is holding a MediaDevice until we're in final-CC, which may imply something was held "late" before it released during the shutdown sequence, and then in final-CC it was caught up with and killed (and caused this).

We could hack to to dump the held Images (mImage) in video sources on a shutdown observer, but that's a bandaid.

We could modify things to not give up on images until after final-CC - but this may be impossible, since likely we shut down critical elements before it.

We could hunt down why this was held until final-CC; that may not be easy, but if we can repro this with rr (probably so) this might be possible to figure out easily (solving may be more hard).

The interesting part here is something is holding a MediaDevice directly it appears.
Component: Graphics → WebRTC: Audio/Video
Flags: needinfo?(rjesup)
Rank: 17
Priority: -- → P1
I wonder if this is the same root cause for the leaks we're getting on Aurora ASAN runs since e10s-multi was enabled there.
https://treeherder.mozilla.org/logviewer.html#?job_id=88727603&repo=mozilla-aurora
Turns out the leaks have been there since this test landed, but LSAN leak checking is broken on trunk due to bug 1353858 :\. Per discussion with jesup, I'm going to skip the test on ASAN for now and he said he can investigate more next week.
Flags: needinfo?(rjesup)
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/72c867371b30
Skip browser_devices_get_user_media_multi_process.js on ASAN due to leaks.
See Also: → 1374164
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Whiteboard: [stockwell fixed:product]
Joel, this test is still being skipped on debug/ASAN. We should probably see if it still needs to be since the annotation in the manifest is point at this bug, now resolved.
Flags: needinfo?(rjesup) → needinfo?(jmaher)
I did a try push:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=33c9798c52eea36398a435e7afbb0d86f589e74d

you can see on osx and windows we hit this same assertion, but it looks to be ok on linux and asan- should we reopen this bug, or mark it as [stockwell disabled] ?
Flags: needinfo?(jmaher)
Let's file a new bug for the OSX/Win asserts then update the annotations to only skip on those platforms with a reference to the new bug.
Blocks: 1393761
bug 1393761 for osx/win
Comment on attachment 8901170 [details] [diff] [review]
enable test for linux debug/asan

Review of attachment 8901170 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/test/webrtc/browser.ini
@@ +10,5 @@
>  [browser_devices_get_user_media_anim.js]
>  [browser_devices_get_user_media_in_frame.js]
>  skip-if = debug # bug 1369731
>  [browser_devices_get_user_media_multi_process.js]
> +skip-if = debug && (os == "win" || os == "mac") # bug 1347625

Please reference bug 1393761 here instead of 1347625.
Attachment #8901170 - Flags: review?(ryanvm) → review+
Pushed by jmaher@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/69c7fb127acf
enable browser_devices_get_user_media_multi_process.js for linux debug/asan. r=RyanVM
Blocks: 1393934
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
Assignee: nobody → jmaher
You need to log in before you can comment on or make changes to this bug.