1347643 - nsHTMLTags::CaseSensitiveLookupTag is too slow

Status: RESOLVED WORKSFORME

(Core :: DOM: HTML Parser, enhancement, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

It is doing a slow hashtable lookup. We probably need some local cache for recently used values.

Comment 1

[Andrew Overholt [:overholt]]

Henri, do you have time to take a look?

Comment 2

[Henri Sivonen (:hsivonen)]

I'll take a look. My preliminary opinion is that we should complicate the HTML5 parser my moving the node creation function pointers onto nsHtml5ElementName and delete nsHTMLTags.cpp.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Whatever works.
If moving stuff to HTML5 Parser is too complicated, a local cache might be good enough.
We have such cache for example for content lists, since doing a hashtable lookup is too slow
http://searchfox.org/mozilla-central/rev/9af9b1c7946ebef6056d2ee4c368d496395cf1c8/dom/base/nsContentList.cpp#191-193,201-204

Comment 4

[Henri Sivonen (:hsivonen)]

Attachment: Bug 1347643 - Put content creator function pointers onto nsHtml5ElementName.

Review commit: https://reviewboard.mozilla.org/r/155236/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/155236/

Comment 5

[Henri Sivonen (:hsivonen)]

Attachment: Java changes

Comment 6

[Henri Sivonen (:hsivonen)]

Known todo: Supporting the Tor prefs for disabling SVG and disabling MathML.

Comment 7

[Henri Sivonen (:hsivonen)]

The logic for checking if SVG or MathML is disabled should probably move from nsNameSpaceManager.cpp to nsNodeInfoManager.cpp.

Comment 8

[Henri Sivonen (:hsivonen)]

The patches here apply on top of those in bug 1266495.

Comment 9

[Henri Sivonen (:hsivonen)]

I'll be away from Bugzilla until July 31st, so if there's a Quantum Flow need to drive this patch in the tree before that, I'm OK with someone else getting this landed. Otherwise, I'll pursue landing this when I'm back.

Comment 10

[Henri Sivonen (:hsivonen)]

Comment on attachment 8884291 [details]
Bug 1347643 - Put content creator function pointers onto nsHtml5ElementName.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155236/diff/1-2/

Comment 11

[Henri Sivonen (:hsivonen)]

Comment on attachment 8884291 [details]
Bug 1347643 - Put content creator function pointers onto nsHtml5ElementName.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155236/diff/2-3/

Comment 12

[Henri Sivonen (:hsivonen)]

Comment on attachment 8884291 [details]
Bug 1347643 - Put content creator function pointers onto nsHtml5ElementName.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/155236/diff/3-4/

Comment 13

[Henri Sivonen (:hsivonen)]

Comment on attachment 8884295 [details] [diff] [review]
Java changes

I'm going with a narrower fix than what the report here identifies as the problem, so moving to the narrower dependency: bug 483155.

Comment 14

[Andrew Overholt [:overholt]]

Olli, do you think we should keep this open? Bug 483155 may have removed the need to do anything here.

Comment 15

[Olli Pettay [:smaug][[e-mail]]]

Don't see this stuff in Speedometer perf profiles atm.