1347651 - Missing focus ring in findbar options buttons in OSX

Status: RESOLVED WORKSFORME

(Firefox :: Theme, defect)

Description

[Sam Foster [:sfoster] (he/him)]

Attachment: screenshot of the find toolbar and no indication of focus

In OSX, if you place focus in the findbar and hit [TAB] a couple times to get to the "Highlight All" button, you can hit space to toggle it, but there's no visual indication that it is focused. Same is true for the other "Match Case" and "Whole Words" buttons on that toolbar.

Comment 1

[:Gijs (he/him)]

Mike, any idea why this is?

(this is broken at least back to 50.1, so I guess we've been shipping this for a while. :-( )

Comment 2

[Mike de Boer [:mikedeboer]]

I think this was introduced by bug 891258. I don't know if Tim has time to look at this, perhaps? I think that this is also affecting Windows and Linux.

Comment 3

[Tim Nguyen :ntim]

Attachment: Bug 1347651 - Fix .findbar-button OSX focusring.

Review commit: https://reviewboard.mozilla.org/r/123596/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123596/

Comment 4

[Mike de Boer [:mikedeboer]]

Comment on attachment 8851226 [details]
Bug 1347651 - Fix .findbar-button OSX focusring.

https://reviewboard.mozilla.org/r/123596/#review126296

What happens when you hover a focused findbar button with this patch applied? (I think it disappears, because you didn't add that rule yet)

::: browser/themes/osx/browser.css:679
(Diff revision 1)
>  toolbar .toolbarbutton-1[checked]:not(:active):hover {
>    background-color: var(--toolbarbutton-checkedhover-backgroundcolor);
>    transition: background-color 250ms;
>  }
>  
> +.findbar-button:not([disabled=true])[checked="true"]:-moz-focusring {

Please put this override directly below the rule it's  overriding and it's better to make it match exactly.
```css
.findbar-button:not([disabled=true]):-moz-any([checked="true"],:hover:active):-moz-focusring {
```

Comment 5

[Tim Nguyen :ntim]

Unassigning to reflect real status.

Comment 6

[Morgan Reschenberg [:morgan]]

/triaging a11y backlog
This appears fixed in Nightly 100, macOS 12.3
Please reopen if this is incorrect.