|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
In browser_bug431826.js, on two occasions we use a custom waitForEvent call that listens to DOMContentLoaded, which is prone to cause intermittent errors. We should replace both with the more reliable BrowserTestUtils.waitForErrorPage function and make sure the affected tests still run correctly.  http://searchfox.org/mozilla-central/rev/ca7015fa45b30b29176fbaa70ba0a36fe9263c38/browser/base/content/test/general/browser_bug431826.js#8,33  http://searchfox.org/mozilla-central/rev/8fa84ca6444e2e01fb405e078f6d2c8da0e55723/testing/mochitest/BrowserTestUtils/BrowserTestUtils.jsm#689 You can run the test with ./mach mochitest browser/base/content/test/general/browser_bug431826.js and learn more about Mochitest here: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/Mochitest
Can I assigned me to this bug?
Thanks! Let me know if you have any questions. :)
Assignee: nobody → alesilva241
Status: NEW → ASSIGNED
Priority: -- → P5
Hi Alexandra, I'm unassigning you for now. Let me know if you still want to work on it.
Assignee: alesilva241 → nobody
Status: ASSIGNED → NEW
Comment on attachment 8857921 [details] bug 1347677 - Use BrowserTestUtils.waitForErrorPage in browser_bug431826.js. https://reviewboard.mozilla.org/r/129954/#review132512 Looks great, thank you! Now we need to trigger a try build (https://wiki.mozilla.org/ReleaseEngineering/TryServer) to make sure all tests are still passing. I'll also set the checkin-needed flag. That means if the try run looks good, someone will land the patch for us.
Attachment #8857921 - Flags: review?(jhofmann) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/f709675d6a79 Use BrowserTestUtils.waitForErrorPage in browser_bug431826.js. r=johannh
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.