1347677 - Use BrowserTestUtils.waitForErrorPage in browser_bug431826.js

Status: RESOLVED FIXED

(Firefox :: Security, enhancement, P5)

Description

[Johann Hofmann [:johannh]]

In browser_bug431826.js, on two occasions[0] we use a custom waitForEvent call that listens to DOMContentLoaded, which is prone to cause intermittent errors. We should replace both with the more reliable BrowserTestUtils.waitForErrorPage[1] function and make sure the affected tests still run correctly.

[0] http://searchfox.org/mozilla-central/rev/ca7015fa45b30b29176fbaa70ba0a36fe9263c38/browser/base/content/test/general/browser_bug431826.js#8,33
[1] http://searchfox.org/mozilla-central/rev/8fa84ca6444e2e01fb405e078f6d2c8da0e55723/testing/mochitest/BrowserTestUtils/BrowserTestUtils.jsm#689

You can run the test with

./mach mochitest browser/base/content/test/general/browser_bug431826.js

and learn more about Mochitest here: https://developer.mozilla.org/en-US/docs/Mozilla/Projects/Mochitest

Comment 1

[Alexandra Silva (:alexandra_)]

Can I assigned me to this bug?

Comment 2

[Johann Hofmann [:johannh]]

Thanks! Let me know if you have any questions. :)

Comment 3

[Johann Hofmann [:johannh]]

Hi Alexandra,

I'm unassigning you for now. Let me know if you still want to work on it.

Comment 4

[Dan Banner]

Attachment: bug 1347677 - Use BrowserTestUtils.waitForErrorPage in browser_bug431826.js.

Review commit: https://reviewboard.mozilla.org/r/129954/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/129954/

Comment 5

[Johann Hofmann [:johannh]]

Comment on attachment 8857921 [details]
bug 1347677 - Use BrowserTestUtils.waitForErrorPage in browser_bug431826.js.

https://reviewboard.mozilla.org/r/129954/#review132512

Looks great, thank you!

Now we need to trigger a try build (https://wiki.mozilla.org/ReleaseEngineering/TryServer) to make sure all tests are still passing. I'll also set the checkin-needed flag. That means if the try run looks good, someone will land the patch for us.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f709675d6a79
Use BrowserTestUtils.waitForErrorPage in browser_bug431826.js. r=johannh

Comment 7

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/f709675d6a79