|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
When I try to run the xpcshell tests in a one click loaner, I get this weird error: root@25dd0bbdc987:~# mach xpcshell-test devtools/server/tests/unit/test_eventlooplag_actor.js Error running mach: ['xpcshell-test', 'devtools/server/tests/unit/test_eventlooplag_actor.js'] The error occurred in the implementation of the invoked mach command. This should never occur and is likely a bug in the implementation of that command. Consider filing a bug for this issue. If filing a bug, please include the full output of mach, including this error message. The details of the failure are as follows: AttributeError: 'Namespace' object has no attribute 'e10s' File "/home/worker/workspace/build/tests/xpcshell/mach_test_package_commands.py", line 65, in xpcshell return run_xpcshell(self.context, **kwargs) File "/home/worker/workspace/build/tests/xpcshell/mach_test_package_commands.py", line 25, in run_xpcshell args.e10s = context.mozharness_config.get('e10s', args.e10s) root@25dd0bbdc987:~# mach --e10s xpcshell-test devtools/server/tests/unit/test_eventlooplag_actor.js usage: mach [global arguments] command [command arguments] mach: error: unrecognized arguments: --e10s It's unclear to me why e10s should even be an argument to the xpcshell tests? Doesn't that only make sense in the context of testing the full browser? Am I missing something?
Did more investigation, pretty certain the e10s option does absolutely nothing and can be taken out.
Assignee: nobody → wlachance
Comment on attachment 8847794 [details] Bug 1347686 - Remove e10s argument from mach xpcshell test runner https://reviewboard.mozilla.org/r/120712/#review122682 no e10s for xpcshell
Attachment #8847794 - Flags: review?(jmaher) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/3998666c1aa1 Remove e10s argument from mach xpcshell test runner r=jmaher
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.