1347686 - Running xpcshell via one-click loaner gives e10s error

Status: RESOLVED FIXED

(Firefox Build System :: Mach Core, enhancement)

Description

[William Lachance (:wlach)]

When I try to run the xpcshell tests in a one click loaner, I get this weird error:

root@25dd0bbdc987:~# mach xpcshell-test devtools/server/tests/unit/test_eventlooplag_actor.js
Error running mach:
    ['xpcshell-test', 'devtools/server/tests/unit/test_eventlooplag_actor.js']
The error occurred in the implementation of the invoked mach command.
This should never occur and is likely a bug in the implementation of that
command. Consider filing a bug for this issue.
If filing a bug, please include the full output of mach, including this error
message.
The details of the failure are as follows:
AttributeError: 'Namespace' object has no attribute 'e10s'
  File "/home/worker/workspace/build/tests/xpcshell/mach_test_package_commands.py", line 65, in xpcshell
    return run_xpcshell(self.context, **kwargs)
  File "/home/worker/workspace/build/tests/xpcshell/mach_test_package_commands.py", line 25, in run_xpcshell
    args.e10s = context.mozharness_config.get('e10s', args.e10s)
root@25dd0bbdc987:~# mach --e10s xpcshell-test devtools/server/tests/unit/test_eventlooplag_actor.js
usage: mach [global arguments] command [command arguments]
mach: error: unrecognized arguments: --e10s

It's unclear to me why e10s should even be an argument to the xpcshell tests? Doesn't that only make sense in the context of testing the full browser? Am I missing something?

Comment 1

[William Lachance (:wlach)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fd749b071c80

Comment 2

[William Lachance (:wlach)]

Did more investigation, pretty certain the e10s option does absolutely nothing and can be taken out.

Comment 3

[William Lachance (:wlach)]

Attachment: Bug 1347686 - Remove e10s argument from mach xpcshell test runner

Review commit: https://reviewboard.mozilla.org/r/120712/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/120712/

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8847794 [details]
Bug 1347686 - Remove e10s argument from mach xpcshell test runner

https://reviewboard.mozilla.org/r/120712/#review122682

no e10s for xpcshell

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3998666c1aa1
Remove e10s argument from mach xpcshell test runner r=jmaher

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3998666c1aa1