|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:51.0) Gecko/20100101 Firefox/51.0 Build ID: 20170125094131 Steps to reproduce: Set packet loss rate at the media server . Actual results: look at the value of the function getstat. the incoming audio packet loss is always zero . the outgoing audio packet loss is not zero . the incoming video packet loss is not zero . the outgoing video packet loss is not zero. the same value as the about:webrtc page. Expected results: the incoming audio packet loss should not be zero
This issue was caused by: ##Files name: media/webrtc/trunk/webrtc/voice_engine/channel.cc ##Function name: int Channel::GetRTPStatistics( unsigned int& averageJitterMs, unsigned int& maxJitterMs, unsigned int& discardedPackets, unsigned int& cumulativeLost) ##Issued code:（I'm not sure the exactly line number...） cumulativeLost = stats.cumulative_lost; // <----- The original code, missed the member "rtcp". The compiler did not tell this issue, why??? ##Correct code： cumulativeLost = stats.rtcp.cumulative_lost; // <--- The correct code I check this issue against Firefox 51 source archive. Hope it could help.
The reason it compiles is this: http://searchfox.org/mozilla-central/source/media/webrtc/trunk/webrtc/voice_engine/channel.cc#150 ChannelStatistics extends RtcpStatistics, so itself has a cumulativeLost value. But it also defines RtcpStatistics as its member |rtcp|. Not confusing at all :-(
And awesome work guys for not only reporting this, but also tracking it down!
Comment on attachment 8849277 [details] Bug 1347813: take cumulativeLost from RTCP. https://reviewboard.mozilla.org/r/122092/#review124250
(In reply to Nils Ohlmeier [:drno] from comment #4) > And awesome work guys for not only reporting this, but also tracking it down! Thanks for your reply. Glad it could help :)
Reminder to check on try results.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/0a0f9c8ff541 take cumulativeLost from RTCP. r=jesup