1347830 - Remove list.txt from Firefox for Android

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Search Activity, enhancement, P3)

Description

[Francesco Lodolo [:flod]]

I believe we forgot to actually remove list.txt in bug 1300201, unless I'm missing something and we still need to keep around the file.

While searching for list.txt in /mobile, I also found a couple of references.

https://dxr.mozilla.org/mozilla-central/rev/ff04d410e74b69acfab17ef7e73e7397602d5a68/mobile/android/installer/allowed-dupes.mn#48
This one seems unnecessary at this point.

https://dxr.mozilla.org/mozilla-central/rev/ff04d410e74b69acfab17ef7e73e7397602d5a68/mobile/locales/Makefile.in#58
I have no clue about this one, it looks like the entire block could go?

Comment 1

[Mike Kaply [:mkaply]]

Yep, you're right. Should have looked for the actual text to find these references.

Comment 2

[Mike Kaply [:mkaply]]

Attachment: Bug 1347830 - Remove actual list.txt and remaining references.

Review commit: https://reviewboard.mozilla.org/r/121072/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121072/

Comment 3

[Mike Kaply [:mkaply]]

Comment on attachment 8848108 [details]
Bug 1347830 - Remove actual list.txt and remaining references.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/121072/diff/1-2/

Comment 4

[Francesco Lodolo [:flod]]

Comment on attachment 8848108 [details]
Bug 1347830 - Remove actual list.txt and remaining references.

https://reviewboard.mozilla.org/r/121072/#review122992

Looks good to me.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/048e51956b6c
Remove actual list.txt and remaining references. r=flod

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/048e51956b6c