Remove list.txt from Firefox for Android

RESOLVED FIXED in Firefox 55

Status

()

Firefox for Android
Search Activity
P3
normal
RESOLVED FIXED
8 months ago
8 months ago

People

(Reporter: flod, Assigned: mkaply)

Tracking

Trunk
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

8 months ago
I believe we forgot to actually remove list.txt in bug 1300201, unless I'm missing something and we still need to keep around the file.

While searching for list.txt in /mobile, I also found a couple of references.

https://dxr.mozilla.org/mozilla-central/rev/ff04d410e74b69acfab17ef7e73e7397602d5a68/mobile/android/installer/allowed-dupes.mn#48
This one seems unnecessary at this point.

https://dxr.mozilla.org/mozilla-central/rev/ff04d410e74b69acfab17ef7e73e7397602d5a68/mobile/locales/Makefile.in#58
I have no clue about this one, it looks like the entire block could go?
(Reporter)

Updated

8 months ago
Flags: needinfo?(mozilla)
(Assignee)

Comment 1

8 months ago
Yep, you're right. Should have looked for the actual text to find these references.
Flags: needinfo?(mozilla)
Comment hidden (mozreview-request)
(Reporter)

Updated

8 months ago
Assignee: nobody → mozilla
Comment hidden (mozreview-request)
(Reporter)

Comment 4

8 months ago
mozreview-review
Comment on attachment 8848108 [details]
Bug 1347830 - Remove actual list.txt and remaining references.

https://reviewboard.mozilla.org/r/121072/#review122992

Looks good to me.
Attachment #8848108 - Flags: review?(francesco.lodolo) → review+

Comment 5

8 months ago
Pushed by mozilla@kaply.com:
https://hg.mozilla.org/integration/autoland/rev/048e51956b6c
Remove actual list.txt and remaining references. r=flod
https://hg.mozilla.org/mozilla-central/rev/048e51956b6c
Status: NEW → RESOLVED
Last Resolved: 8 months ago
status-firefox55: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
You need to log in before you can comment on or make changes to this bug.