Closed Bug 1347834 Opened 5 years ago Closed 5 years ago

Get audio codec specific data from parser

Categories

(Core :: Audio/Video: Playback, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: ayang, Assigned: ayang)

References

Details

Attachments

(2 files, 1 obsolete file)

Some PlatformDecoderModule like ffmpeg requires this field to initialize decoder.
Assignee: nobody → ayang
Blocks: 1161350
Comment on attachment 8847991 [details]
Bug 1347834 - retrieve audio codec specific config from rust parser.

https://reviewboard.mozilla.org/r/120948/#review123198
Attachment #8847991 - Flags: review?(kinetik) → review+
Attachment #8847991 - Attachment is obsolete: true
Comment on attachment 8848360 [details]
Bug 1347834 - retrieve audio codec specific config from rust parser.

https://reviewboard.mozilla.org/r/121262/#review123286

carry previous r+
Attachment #8848360 - Flags: review+
Attachment #8848360 - Flags: review?(kinetik)
Comment on attachment 8848358 [details]
Bug 1347834 - update rust mp4 parser for audio codec specific data.

https://reviewboard.mozilla.org/r/121256/#review123288
Attachment #8848358 - Flags: review?(kinetik) → review+
Attachment #8848360 - Flags: review?(kinetik)
(In reply to Matthew Gregan [:kinetik] from comment #3)
> Comment on attachment 8847991 [details]
> Bug 1347834 - retrieve audio codec specific config from rust parser.
> 
> https://reviewboard.mozilla.org/r/120948/#review123198

Mozreview removes the previous r+ when I push another patch, could you please r+ it again? Sorry for inconvenience.
Priority: -- → P3
Comment on attachment 8848360 [details]
Bug 1347834 - retrieve audio codec specific config from rust parser.

https://reviewboard.mozilla.org/r/121262/#review123556
Attachment #8848360 - Flags: review?(kinetik) → review+
Pushed by ayang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/51c124a0f50b
retrieve audio codec specific config from rust parser. r=kinetik
https://hg.mozilla.org/integration/autoland/rev/32e03588ec39
update rust mp4 parser for audio codec specific data. r=kinetik
https://hg.mozilla.org/mozilla-central/rev/51c124a0f50b
https://hg.mozilla.org/mozilla-central/rev/32e03588ec39
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.