1347838 - Assertion failure: !IsResolved() (already resolved), at /home/worker/workspace/build/src/layout/style/nsStyleStruct.cpp:2005

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Carsten Book [:Tomcat]]

Attachment: bughunter stack

Assertion failure: !IsResolved() (already resolved), at /home/worker/workspace/build/src/layout/style/nsStyleStruct.cpp:2005

found during topsite tests and reproduced on latest stylo debug build from tinderbox.

Steps to reproduce:

-> Load http://www.theatlanticcities.com
---> Assertion failure within 10 seconds of loading the page

Comment 1

[Cameron McCormack (:heycam)]

Attachment: Bug 1347838 - stylo: Don't resolve images in nsStyleContentData objects twice.

Review commit: https://reviewboard.mozilla.org/r/121614/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121614/

Comment 2

[Cameron McCormack (:heycam)]

I missed this when reviewing bug 1296477.  (We need to check whether we've already resolve in case we e.g. inherited the same nsStyleImageRequest object from a parent, or we shared ServoComputedValues objects with another element.)

Comment 3

[Manish Goregaokar [:manishearth]]

Comment on attachment 8848714 [details]
Bug 1347838 - stylo: Don't resolve images in nsStyleContentData objects twice.

https://reviewboard.mozilla.org/r/121614/#review123636

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fa214885f96f
stylo: Don't resolve images in nsStyleContentData objects twice. r=manishearth

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fa214885f96f