13479 - MLK: leak of 116 bytes - File channel or protocol handler or nsThreadPool?

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[Bruce Mitchener]

This was from a September 7, 1999 build on NT.

[W] MLK: Memory leak of 116 bytes from 1 block allocated in beginthreadex
        Distribution of leaked blocks
               116 bytes from 1 block of 116 bytes (0x036fb558) allocation
number 22745
        Allocation location
            calloc_dbg     [dbgheap.c:495]
            beginthreadex  [threadex.c:108]
            PR_MD_CREATE_THREAD [w95thred.c:106]
            PR_NativeCreateThread [pruthr.c:1037]
            PR_CreateThread [pruthr.c:1152]
            PR_CreateThread [pruthr.c:1360]
            nsThread::Init(nsIRunnable
*,UINT,PRThreadPriority,PRThreadScope,PRThreadState) [nsThread.cpp:76]
            NS_NewThread(nsIThread * *,nsIRunnable
*,UINT,PRThreadPriority,PRThreadScope,PRThreadState) [nsThread.cpp:212]
            nsThreadPool::Init(UINT,PRThreadPriority,PRThreadScope)
[nsThread.cpp:340]
            NS_NewThreadPool(nsIThreadPool *
*,UINT,UINT,UINT,PRThreadPriority,PRThreadScope) [nsThread.cpp:518]
            nsFileProtocolHandler::Init(void) [nsFileProtocolHandler.cpp:50]
            nsFileProtocolHandler::Create(nsISupports *,nsID const&,void * *)
[nsFileProtocolHandler.cpp:74]
            nsGenericFactory::CreateInstance(nsISupports *,nsID const&,void * *)
[nsGenericFactory.cpp:37]
            nsComponentManagerImpl::CreateInstance(nsID const&,nsISupports
*,nsID const&,void * *) [nsComponentManager.cpp:1203]
            nsComponentManager::CreateInstance(nsID const&,nsISupports *,nsID
const&,void * *) [nsRepository.cpp:77]

Comment 1

[Warren Harris]

This is because the file transport thread(s) hang around forever. Same with the
socket transport threads. I guess we could/should add a shutdown call for them.

Comment 2

[Warren Harris]

I fixed this a week or so ago.

Comment 3

[Paul MacQuiddy]

verified

Comment 4

[leger]

Bulk move of all Necko (to be deleted component) bugs to new Networking

component.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49e297828019
[fenix] for https://github.com/mozilla-mobile/fenix/issues/13479, added a VisualCompletenessQueue.kt class to handle all the functionality related to visual completeness