1347944 - Uplift three crash fixes to beta and/or aurora

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, defect, P1)

Description

[Paul Adenot (:padenot)]

Attached is a beta patch for those bugs:
- Bug 1342389
- Bug 1345147
- Bug 1347453

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Per IRC discussion, we may want to consider doing some backports to esr52 as well, but the situation for including them as an Fx52 dot release ride-along is more murky.

Comment 2

[Paul Adenot (:padenot)]

Attachment: Uplift three crash fixes to beta

This is simply cherry picked from recent patches.

Comment 3

[Paul Adenot (:padenot)]

Attachment: Uplift three crash fixes to beta

This is the patch to land for beta.

MozReview-Commit-ID: LdcXcbTFxqL

Comment 4

[Paul Adenot (:padenot)]

Attachment: Uplift three crash fixes to aurora

This is the patch rebased for aurora.

Comment 5

[Paul Adenot (:padenot)]

Comment on attachment 8848534 [details] [diff] [review]
Uplift three crash fixes to beta

Approval Request Comment
[Feature/Bug causing the regression]: fallout from bug 1314514 where we made a crash less worrisome and reduced its volume
[User impact if declined]: low volume crashes
[Is this code covered by automated tests?]: no, we don't even know how this happens in the first place. One of the crash has a test upstream that we have disabled here because it takes too long, but we'll fix that soon (https://github.com/kinetiknz/cubeb/blob/master/test/test_overload_callback.cpp)
[Has the fix been verified in Nightly?]: yes, it's been landed for some time now
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: this is specifically prepared so that it can land on its own
[Is the change risky?]: no
[Why is the change risky/not risky?]: we've seen a drop in crashes in nightlies (but it's a bit hard to tell because it's low volume in the first place)
[String changes made/needed]: none

Comment 6

[Paul Adenot (:padenot)]

Comment on attachment 8848535 [details] [diff] [review]
Uplift three crash fixes to aurora

Approval Request Comment
[Feature/Bug causing the regression]: fallout from bug 1314514 where we made a crash less worrisome and reduced its volume
[User impact if declined]: low volume crashes
[Is this code covered by automated tests?]: no, we don't even know how this happens in the first place. One of the crash has a test upstream that we have disabled here because it takes too long, but we'll fix that soon (https://github.com/kinetiknz/cubeb/blob/master/test/test_overload_callback.cpp)
[Has the fix been verified in Nightly?]: yes, it's been landed for some time now
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: this is specifically prepared so that it can land on its own
[Is the change risky?]: no
[Why is the change risky/not risky?]: we've seen a drop in crashes in nightlies (but it's a bit hard to tell because it's low volume in the first place)
[String changes made/needed]: none

Comment 7

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8848534 [details] [diff] [review]
Uplift three crash fixes to beta

Fix for a/v crash, let's uplift to beta. It may not land until Thursday's beta 6 build.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/93b358d61a9b

Comment 9

[Ryan VanderMeulen [:RyanVM]]

The Beta patch needs rebasing.

Comment 10

[Paul Adenot (:padenot)]

Attachment: Uplift three crash fixes to beta

This is rebased on top of current beta. I must have written the patch on top of
an old tree, sorry about that.

Comment 11

[Paul Adenot (:padenot)]

Fixed, sorry about that.

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/36c50c1294eb

Comment 13

[Liz Henry (:lizzard Please n-i to RyanVM, jcristau, or pascal)]

Fixed in beta, we still may want to bring the one fix that affects esr52 into esr though.

Comment 15

[Cornel Ionce [:noni] [Hubs QA]]

Setting qe-verify- based on comment 5.

Comment 16

[Ryan VanderMeulen [:RyanVM]]

Other than a conflict in update.sh that'd be trivial to rebase around, this grafts cleanly to esr52. Please request approval when you're comfortable doing so.

Comment 17

[Paul Adenot (:padenot)]

Comment on attachment 8849533 [details] [diff] [review]
Uplift three crash fixes to beta

[Approval Request Comment]
If this is not a sec:{high,crit} bug, please state case for ESR consideration: this fixes crashes
User impact if declined: it will crash a little bit more 
Fix Landed on Version: 53, 54, 55
Risk to taking this patch (and alternatives if risky): not really risky, we've landed that on a bunch of branches, and it does fix three different crashes (we've looked at crash-stats in the following days). 
String or UUID changes made by this patch: none

See https://wiki.mozilla.org/Release_Management/ESR_Landing_Process for more info.

Comment 18

[Julien Cristau [:jcristau]]

Comment on attachment 8849533 [details] [diff] [review]
Uplift three crash fixes to beta

cubeb crash fix for 52.1.0esr

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/47cb652ddc25