1347947 - Move static checking browser mochitests to their own folder

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Florian Quèze [:florian]]

We already have a few browser mochitests performing tests on all the files we are shipping. I think they deserve their own folder, as I'm going to add more soon (starting with bug 1316187).

The patch I will attach also does some cleanup to these tests:
- In browser_parsable_script.js I fixed location information for warnings from the JS parser, and made the test cover toolkit files in addition to browser files. (equivalent of the changes made in bug 1221383 to the css test)
- In browser_parsable_css.js I removed usage of Promise.jsm
- In browser_misused_characters_in_strings.js setting the xhr response type to text avoid lots of XML parse error in the terminal.

I changed parsingTestHelpers.jsm to a head.js file as it's really only needed for tests that will live in this folder, and all of them will need it.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

Comment 2

[Florian Quèze [:florian]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d15cf04a697

Comment 3

[:Gijs (he/him)]

Comment on attachment 8848095 [details] [diff] [review]
Patch

Review of attachment 8848095 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, but please also update https://dxr.mozilla.org/mozilla-central/source/tools/lint/eslint/modules.json#167

Comment 4

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b5df0025c79dc5cce54216194ab9ba8ddb38d222
Bug 1347947 - Move static checking browser mochitests to their own folder, r=Gijs.

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b5df0025c79d