1348136 - stylo: ServoElementSnapshot::AddAttrs should do the HasAny() check in an inline path

Status: NEW

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Boris Zbarsky [:bzbarsky]]

Save a function call on hot paths.

Comment 1

[Bobby Holley (:bholley)]

Note that we're already doing an atomic op here to borrow the AtomicRefCell. If that's too hot, we could put the ElementSnapshot directly on the Element (rather than in the ElementData), since it's only ever mutated on the main thread.

Comment 2

[Boris Zbarsky [:bzbarsky]]

I think long-term that will be the right thing to do; it will let us skip a bunch of function calls and FFI and so forth.

We can't do all the savings until we nix the gecko style system, though.

Comment 3

[Chris Peterson [:cpeterson]]

status-firefox57=wontfix unless someone thinks this bug should block 57