Open
Bug 1348136
Opened 8 years ago
Updated 2 years ago
stylo: ServoElementSnapshot::AddAttrs should do the HasAny() check in an inline path
Categories
(Core :: CSS Parsing and Computation, enhancement, P4)
Core
CSS Parsing and Computation
Tracking
()
NEW
People
(Reporter: bzbarsky, Unassigned)
References
(Blocks 1 open bug)
Details
Save a function call on hot paths.
Updated•8 years ago
|
Priority: -- → P4
Comment 1•8 years ago
|
||
Note that we're already doing an atomic op here to borrow the AtomicRefCell. If that's too hot, we could put the ElementSnapshot directly on the Element (rather than in the ElementData), since it's only ever mutated on the main thread.
Reporter | ||
Comment 2•8 years ago
|
||
I think long-term that will be the right thing to do; it will let us skip a bunch of function calls and FFI and so forth.
We can't do all the savings until we nix the gecko style system, though.
Comment 3•7 years ago
|
||
status-firefox57=wontfix unless someone thinks this bug should block 57
status-firefox57:
--- → wontfix
Updated•2 years ago
|
Severity: normal → S3
You need to log in
before you can comment on or make changes to this bug.
Description
•