Closed Bug 1348148 Opened 3 years ago Closed 3 years ago

fix assertion failure in Accessible::HandleAccEvent() that there is an ipc doc

Categories

(Core :: Disability Access APIs, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Details

Attachments

(1 file)

It is awkward to need to have a DocAccessibleChild to send events with before
DocAccessible::DoInitialUpdate() is called because we might not have a
TabParent for the document until then.  However we could try to fire reload
events on documents before DoInitialUpdate() was called which would require
having a DocAccessibleChild there to send the load event to the parent process.

However before DocAccessible::DoInitialUpdate() is called the document already
has a pending load event.  If a document hasn't yet been the subject of a load
event it doesn't make a lot of sense to fire a reload event for that document,
      and then the initial load event.  So it should be safe to skip firing
      reload events for documents where mLoadEvent specifies a load event to
      fire in the future.
Attachment #8848302 - Flags: review?(dbolter) → review+
(In reply to Trevor Saunders (:tbsaunde) from comment #0)
> If a document hasn't yet been the subject of a
> load
> event it doesn't make a lot of sense to fire a reload event for that
> document,
>       and then the initial load event.  So it should be safe to skip firing
>       reload events for documents where mLoadEvent specifies a load event to
>       fire in the future.

you should put comments like this right into the code.
Pushed by tsaunders@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a08bfa91d2b
try and avoid firing load events on unloaded documents r=davidb
https://hg.mozilla.org/mozilla-central/rev/5a08bfa91d2b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Assignee: nobody → tbsaunde+mozbugs
You need to log in before you can comment on or make changes to this bug.