1348200 - Imagebitmap extensions tests are impossible to run locally

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Running this:

  mach mochitest dom/canvas/test/test_imagebitmap_extensions.html

fails because the test never manages to load the video.  It fails to load because it gets a 404.

The problem, I suspect, is that this test lists neither the sjs it's loading nor the video it asks the sjs to read in support_files.  And then they're not present in the objdir and things go haywire...

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: hack that allows running dom/canvas/test/test_imagebitmap_extensions_on_worker.html

... but probably breaks other things

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

(Actually, this patch might be right.  But I really didn't look closely.)

Comment 3

[(no longer active)]

ping?

Comment 4

[Tzuhao Kuo [:kaku]]

The problem happens not only to the Imagebitmap extensions tests, but also to the Imagebitmap tests. 

(In reply to David Baron :dbaron: ⌚️UTC+8 from comment #1)
> Created attachment 8848388 [details] [diff] [review]
> hack that allows running
> dom/canvas/test/test_imagebitmap_extensions_on_worker.html
> 
> ... but probably breaks other things

I think the patch is jut right and does not break any other thing. I will then extend it to fix both Imagebitmap tests and Imagebitmap extensions tests.

Comment 5

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1348200 P1 - prepare resources;

Put crossorigin/image.png, crossorigin/video.sjs, and media/test/320x240.ogv into mochitest.ini.

Review commit: https://reviewboard.mozilla.org/r/128376/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128376/

Comment 6

[Tzuhao Kuo [:kaku]]

Attachment: Bug 1348200 P2 - use resources in dom/canvas/test;

Followed by P1, we can use resources in dom/canvas/test now.

Review commit: https://reviewboard.mozilla.org/r/128378/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/128378/

Comment 7

[Tzuhao Kuo [:kaku]]

Try:https://treeherder.mozilla.org/#/jobs?repo=try&revision=5d8ea84137224ffed6497d0975cff283fc416609&selectedJob=90031664

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8856419 [details]
Bug 1348200 P1 - prepare resources;

https://reviewboard.mozilla.org/r/128376/#review130860

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8856420 [details]
Bug 1348200 P2 - use resources in dom/canvas/test;

https://reviewboard.mozilla.org/r/128378/#review130862

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Did you test that all of the imagebitmap tests now work correctly when run on their own, with these patches?

Comment 11

[Tzuhao Kuo [:kaku]]

(In reply to David Baron :dbaron: ⌚️UTC+8 from comment #10)
> Did you test that all of the imagebitmap tests now work correctly when run
> on their own, with these patches?

Yes, I tested all the test_imagebitmap*.html files separately with a clean rebuild, they all work well.

Thanks for your review.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b1ab45dd987c
P1 - prepare resources; r=dbaron
https://hg.mozilla.org/integration/autoland/rev/0a82045b1563
P2 - use resources in dom/canvas/test; r=dbaron

Comment 13

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/b1ab45dd987c
https://hg.mozilla.org/mozilla-central/rev/0a82045b1563