Closed Bug 1348209 Opened 3 years ago Closed 3 years ago

Make wr_renderer_readback() as to handle both GL and GLES

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file, 2 obsolete files)

No description provided.
Assignee: nobody → sotaro.ikeda.g
The functions were borrowed from https://github.com/servo/webrender/pull/984.
Blocks: 1323316
Depends on: 1325911
Attachment #8848390 - Flags: review?(bugmail)
Comment on attachment 8848390 [details] [diff] [review]
patch - Make wr_renderer_readback() as to handle both GL and GLES

Review of attachment 8848390 [details] [diff] [review]:
-----------------------------------------------------------------

r+ but in the future I will r- any review request without a commit message, so please make sure to add commit messages going forward.

::: gfx/webrender_bindings/src/bindings.rs
@@ +56,5 @@
>  check_ffi_type!(_namespace_id_repr struct IdNamespace as (u32));
>  
> +const GL_FORMAT_BGRA_GL: gl::GLuint = gl::BGRA;
> +
> +const GL_FORMAT_BGRA_GLES: gl::GLuint = gl::BGRA_EXT;

nit: remove the empty line between these two
Attachment #8848390 - Flags: review?(bugmail) → review+
Attachment #8848390 - Attachment is obsolete: true
Attachment #8849367 - Flags: review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/8680b14ea3d0
Make wr_renderer_readback() as to handle both GL and GLES r=kats
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.