Make wr_renderer_readback() as to handle both GL and GLES

RESOLVED FIXED in Firefox 55

Status

()

Core
Graphics: WebRender
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: sotaro, Assigned: sotaro)

Tracking

unspecified
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment, 2 obsolete attachments)

Comment hidden (empty)
(Assignee)

Updated

9 months ago
Assignee: nobody → sotaro.ikeda.g
(Assignee)

Comment 1

9 months ago
Created attachment 8848390 [details] [diff] [review]
patch - Make wr_renderer_readback() as to handle both GL and GLES
(Assignee)

Comment 2

9 months ago
The functions were borrowed from https://github.com/servo/webrender/pull/984.
(Assignee)

Updated

9 months ago
Blocks: 1323316
Depends on: 1325911
(Assignee)

Updated

9 months ago
Attachment #8848390 - Flags: review?(bugmail)
Comment on attachment 8848390 [details] [diff] [review]
patch - Make wr_renderer_readback() as to handle both GL and GLES

Review of attachment 8848390 [details] [diff] [review]:
-----------------------------------------------------------------

r+ but in the future I will r- any review request without a commit message, so please make sure to add commit messages going forward.

::: gfx/webrender_bindings/src/bindings.rs
@@ +56,5 @@
>  check_ffi_type!(_namespace_id_repr struct IdNamespace as (u32));
>  
> +const GL_FORMAT_BGRA_GL: gl::GLuint = gl::BGRA;
> +
> +const GL_FORMAT_BGRA_GLES: gl::GLuint = gl::BGRA_EXT;

nit: remove the empty line between these two
Attachment #8848390 - Flags: review?(bugmail) → review+
(Assignee)

Comment 4

9 months ago
Created attachment 8849367 [details] [diff] [review]
patch - Make wr_renderer_readback() as to handle both GL and GLES
Attachment #8848390 - Attachment is obsolete: true
Attachment #8849367 - Flags: review+
(Assignee)

Comment 5

9 months ago
Created attachment 8849368 [details] [diff] [review]
patch - Make wr_renderer_readback() as to handle both GL and GLES
Attachment #8849367 - Attachment is obsolete: true
Attachment #8849368 - Flags: review+
(Assignee)

Comment 6

9 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2265e179245749c52c384c1e2be78453615d1ec2

Comment 7

9 months ago
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/projects/graphics/rev/8680b14ea3d0
Make wr_renderer_readback() as to handle both GL and GLES r=kats
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
https://hg.mozilla.org/mozilla-central/rev/8680b14ea3d0
status-firefox55: --- → fixed
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.