1348253 - about:url-classifier: Providers information and update button

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, enhancement, P2)

Description

[Ethan Tseng [:ethan]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1338079#c0

The third section (providers) would show the following information for each provider:
- time of the last update
- last update return status (e.g. 200, 503)

and have a button to force an update for just that provider.

Comment 1

[Dimi Lee [OOO 19.Oct - 23.Oct]]

Attachment: WIP patch

Comment 2

[Dimi Lee [OOO 19.Oct - 23.Oct]]

Attachment: Bug 1348253 - about:url-classifier: Providers information and update button.

This is the first version of about:url-classifier.
It has two main panel(provider & debug) and includes following functionality:
1. Provider panel contains update information(last update time, next update time,
   last update status) for each provider.
2. Update button to force trigger an update for each provider.
3. Debug panel to set debug output and view current debug config.

The remaining functions are not yet implemented includes Lookup, Caching, Database
and Memory.

Review commit: https://reviewboard.mozilla.org/r/123760/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/123760/

Comment 3

[Dimi Lee [OOO 19.Oct - 23.Oct]]

Attachment: screenshot

Attach screenshot, the layout is copyied from about:support

Comment 4

[François Marier [:francois]]

This is going to be really useful!

Two small things, based on the screenshot:

- maybe we should add the ApplicationReputation log module too
- until we have something in the Memory, Database, Cache and Lookup Sections, we should not display them

Also, did you link to this page from about:about?

Comment 5

[Dimi Lee [OOO 19.Oct - 23.Oct]]

(In reply to François Marier [:francois] from comment #4)
> This is going to be really useful!
> 
> Two small things, based on the screenshot:
> 
> - maybe we should add the ApplicationReputation log module too
> - until we have something in the Memory, Database, Cache and Lookup
> Sections, we should not display them
> 

I'll add ApplicationReputation log module and remove sections that we are not yet support.

> Also, did you link to this page from about:about?

Yes!

Comment 6

[Dimi Lee [OOO 19.Oct - 23.Oct]]

Comment on attachment 8851462 [details]
Bug 1348253 - about:url-classifier: Providers information and update button.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123760/diff/1-2/

Comment 7

[François Marier [:francois]]

Comment on attachment 8851462 [details]
Bug 1348253 - about:url-classifier: Providers information and update button.

https://reviewboard.mozilla.org/r/123760/#review129142

This looks really good, thanks Dimi!

Can you please check that it works on Fennec (and ideally include a screenshot)?

I'm not sure if the debug section makes sense on Fennec though, so maybe we should check with a Fennec developer to see if we should include it or if we should only display the provider section there.

::: toolkit/content/aboutUrlClassifier.js:47
(Diff revision 2)
> +    this.render();
> +    this.refresh();
> +  },
> +
> +  register() {
> +    // Handle beging udpate

"begin update"

::: toolkit/content/aboutUrlClassifier.js:64
(Diff revision 2)
> +    // Handle finish update
> +    Services.obs.addObserver((aSubject, aTopic, aData) => {
> +      let p = this.updatingProvider;
> +      this.updatingProvider = "";
> +
> +      // It is possible that we get update-finish event only because

"update-finished"

::: toolkit/content/aboutUrlClassifier.js:177
(Diff revision 2)
> +      this.refreshJSDebug();
> +    }, false);
> +  },
> +
> +  render() {
> +    // This function update the log moudle text field if we click

"module"

::: toolkit/content/aboutUrlClassifier.xhtml:36
(Diff revision 2)
> +          <th id="col-lastupdateresult">&aboutUrlClassifier.providerLastUpdateStatus;</th>
> +          <th id="col-update">&aboutUrlClassifier.providerUpdateBtn;</th>
> +        </tr>
> +      </thead>
> +      <tbody id="provider-table-body">
> +        <!-- data is generate in javascript -->

"generated"

::: toolkit/content/aboutUrlClassifier.xhtml:49
(Diff revision 2)
> +      <button id="set-log-modules">&aboutUrlClassifier.debugModuleBtn;</button>
> +      <br></br>
> +      <input id="log-file" type="text" value=""/>
> +      <button id="set-log-file">&aboutUrlClassifier.debugFileBtn;</button>
> +      <br></br>
> +      <button id="js-log"/>

Maybe this should be a checkbox? "Safe Browsing JS Log"

::: toolkit/locales/en-US/chrome/global/aboutUrlClassifier.dtd:25
(Diff revision 2)
> +<!ENTITY aboutUrlClassifier.memoryTitle                 "Memory">
> +<!ENTITY aboutUrlClassifier.databaseTitle               "Database">
> +<!ENTITY aboutUrlClassifier.debugTitle                  "Debug">
> +<!ENTITY aboutUrlClassifier.debugModuleBtn              "Set Log Modules">
> +<!ENTITY aboutUrlClassifier.debugFileBtn                "Set Log File">
> +<!ENTITY aboutUrlClassifier.debugSBModules              "SafeBrowsing log modules">

"Safe Browsing"

::: toolkit/locales/en-US/chrome/global/aboutUrlClassifier.properties:9
(Diff revision 2)
> +
> +TriggerUpdate = Trigger Update
> +
> +NotAvailable = N/A
> +
> +DisableSBJSLog = Disable SafeBrowsing JS Log

"Safe Browsing"

::: toolkit/locales/en-US/chrome/global/aboutUrlClassifier.properties:11
(Diff revision 2)
> +
> +NotAvailable = N/A
> +
> +DisableSBJSLog = Disable SafeBrowsing JS Log
> +
> +EnableSBJSLog = Enable SafeBrowsing JS Log

ditto

Comment 8

[Dimi Lee [OOO 19.Oct - 23.Oct]]

Comment on attachment 8851462 [details]
Bug 1348253 - about:url-classifier: Providers information and update button.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123760/diff/2-3/

Comment 9

[Ethan Tseng [:ethan]]

(In reply to Dimi Lee[:dimi][:dlee] from comment #3)
> Created attachment 8851463 [details]
> screenshot
> 
> Attach screenshot, the layout is copyied from about:support

This looks pretty good.
I look forward to this feature being rolled out!  :)

Comment 10

[Dimi Lee [OOO 19.Oct - 23.Oct]]

Attachment: screenshot on fennec

Hi Francois,
about:url-classifier works on feenec, attach fennec screnshot.
As for MOZ_LOG log, I think it make sense to me because we can still get the debug message by using "adb logcat" on fennec device.

Comment 11

[Dimi Lee [OOO 19.Oct - 23.Oct]]

Comment on attachment 8851462 [details]
Bug 1348253 - about:url-classifier: Providers information and update button.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123760/diff/3-4/

Comment 12

[François Marier [:francois]]

Comment on attachment 8851462 [details]
Bug 1348253 - about:url-classifier: Providers information and update button.

https://reviewboard.mozilla.org/r/123760/#review133482

Great work!

::: toolkit/content/aboutUrlClassifier.js:47
(Diff revisions 2 - 4)
>      this.render();
>      this.refresh();
>    },
>  
>    register() {
> -    // Handle beging udpate
> +    // Handle beging update

"begin"

Comment 13

[Dimi Lee [OOO 19.Oct - 23.Oct]]

Comment on attachment 8851462 [details]
Bug 1348253 - about:url-classifier: Providers information and update button.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123760/diff/4-5/

Comment 14

[Dimi Lee [OOO 19.Oct - 23.Oct]]

Comment on attachment 8851462 [details]
Bug 1348253 - about:url-classifier: Providers information and update button.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123760/diff/5-6/

Comment 15

[Dimi Lee [OOO 19.Oct - 23.Oct]]

Comment on attachment 8851462 [details]
Bug 1348253 - about:url-classifier: Providers information and update button.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123760/diff/6-7/

Comment 16

[Dimi Lee [OOO 19.Oct - 23.Oct]]

Comment on attachment 8851462 [details]
Bug 1348253 - about:url-classifier: Providers information and update button.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123760/diff/7-8/

Comment 17

[Dimi Lee [OOO 19.Oct - 23.Oct]]

Comment on attachment 8851462 [details]
Bug 1348253 - about:url-classifier: Providers information and update button.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/123760/diff/8-9/

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ce1a738538e
about:url-classifier: Providers information and update button. r=francois

Comment 19

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8ce1a738538e

Comment 20

[Ethan Tseng [:ethan]]

Nice work!  Thank you, Dimi!
Now we have a Safe Browsing debugging page, awesome!!