1348272 - Mark nsIOutputStream as builtinclass

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement, P3)

Description

[Henri Sivonen (:hsivonen)]

We should mark nsIOutputStream as builtinclass in order to be able to stop worrying about bug 170416.

Comment 1

[Henri Sivonen (:hsivonen)]

It seems we still have 3 test cases that implement nsIOutputStream in JS:
https://searchfox.org/mozilla-central/source/netwerk/test/httpserver/test/test_async_response_sending.js#914
https://searchfox.org/mozilla-central/source/dom/base/test/test_encodeToStringWithRequiresReinitAfterOutput.html#58
https://searchfox.org/mozilla-central/source/dom/base/test/chrome/test_domparsing.xul#101

Comment 2

[Andrew McCreight [:mccr8]]

FWIW, it looks like test_async_response_sending.js is the only one of the three tests in comment 1 that still uses nsIOutputStream in JS, at least at a glance. I don't know if there are others.

Comment 3

[Nika Layzell [:nika] (ni? for response)]

We should look into whether we can get rid of that caller, as we definitely don't make sure to null-terminate all calls to nsIOutputStream::write nowadays, and it'd be nice to make sure that we can't add new JS implementations.

Comment 4

[Nika Layzell [:nika] (ni? for response)]

Attachment: Bug 1348272 - Mark nsIInputStream and nsIOutputStream as builtinclass, r=#xpcom-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/10ea141649b6
Mark nsIInputStream and nsIOutputStream as builtinclass, r=xpcom-reviewers,necko-reviewers,barret,valentin

Comment 6

[Marian-Vasile Laza]

Backed out changeset 10ea141649b6 (Bug 1348272) for causing mochitest failures on test_domparsing.xhtml.
Backout link
Push with failures <--> c2
Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1d172cf70c68
Mark nsIInputStream and nsIOutputStream as builtinclass, r=xpcom-reviewers,necko-reviewers,barret,valentin

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/1d172cf70c68