1348286 - KeyError: 'target.awsy.tests.zip' on beetmover signing

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Carsten Book [:Tomcat]]

https://treeherder.mozilla.org/logviewer.html#?job_id=84629619&repo=mozilla-central&lineNumber=108

Callek, do you know who could take a look ?

Comment 1

[Carsten Book [:Tomcat]]

mtabara: could you take a look, thanks!

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

Definitely. Feel free to assign anything beetmover related to me from now on ;-)

Comment 3

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1348286 - add missing target.awsy.tests.zip beetmoverscript templates. r=jlund

Comment 4

[Mihai Tabara [:mtabara]⌚️GMT]

Attachment: Bug 1348286 - add awsy.tests within en-US mobile artifacts too.

Review commit: https://reviewboard.mozilla.org/r/121520/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121520/

Comment 5

[Jordan Lund (:jlund)]

Comment on attachment 8848637 [details]
Bug 1348286 - add awsy.tests within en-US mobile artifacts too.

https://reviewboard.mozilla.org/r/121520/#review123590

::: taskcluster/taskgraph/transforms/beetmover.py:59
(Diff revision 1)
>      "en-US/target.json",
>      "en-US/target.mochitest.tests.zip",
>      "en-US/target.mozinfo.json",
>      "en-US/target.reftest.tests.zip",
>      "en-US/target.talos.tests.zip",
> +    "en-US/target.awsy.tests.zip",

good eye!

Comment 6

[Jordan Lund (:jlund)]

Comment on attachment 8848634 [details] [review]
Bug 1348286 - add missing target.awsy.tests.zip beetmoverscript templates. r=jlund

until the https://bugzilla.mozilla.org/show_bug.cgi?id=1331141 resolution is made, maybe we should at least leave an in-tree comment about required patch in beetmoverscript. e.g. at top of: https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/transforms/beetmover.py#18

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf0558124b71
add awsy.tests within en-US mobile artifacts too. r=jlund a=release DONTBUILD

Comment 8

[Mihai Tabara [:mtabara]⌚️GMT]

(In reply to Jordan Lund (:jlund) from comment #6)
> Comment on attachment 8848634 [details] [review]
> Bug 1348286 - add missing target.awsy.tests.zip beetmoverscript templates.
> r=jlund
> 
> until the https://bugzilla.mozilla.org/show_bug.cgi?id=1331141 resolution is
> made, maybe we should at least leave an in-tree comment about required patch
> in beetmoverscript. e.g. at top of:
> https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/
> transforms/beetmover.py#18

I agree! I've added a comment, thanks for the suggestion.
Bug 1331141 is something I'd really love to tackle in the future. Unification and single-sourcing everything in-tree would be awesome.

Comment 9

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8848637 [details]
Bug 1348286 - add awsy.tests within en-US mobile artifacts too.

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf0558124b71

Comment 10

[Mihai Tabara [:mtabara]⌚️GMT]

Comment on attachment 8848634 [details] [review]
Bug 1348286 - add missing target.awsy.tests.zip beetmoverscript templates. r=jlund

https://github.com/mozilla-releng/beetmoverscript/commit/810127ead556352a790e32a9abe28f6af3bfe2c7

Comment 11

[Mihai Tabara [:mtabara]⌚️GMT]

https://hg.mozilla.org/build/puppet/rev/e39203f92424
Bug 1348286 - bump beetmoverscript in beetmoverworker. r=trivial

Comment 12

[Mihai Tabara [:mtabara]⌚️GMT]

For some reason I missed adding the changes in the initial bump. Apologies for that.

https://hg.mozilla.org/build/puppet/rev/eed4e955a147
Bug 1348286 - bump beetmoverscript again in beetmoverworker. r=trivial

Comment 13

[Mihai Tabara [:mtabara]⌚️GMT]

https://hg.mozilla.org/build/puppet/rev/0cd766403f7f
Bug 1348286 - bump beetmoverscript in beetmoverworker. r=trivial

Comment 14

[Mihai Tabara [:mtabara]⌚️GMT]

Fixed beetmoverscript to take into account the `target.awsy.tests.zip` too. 

Retriggered https://tools.taskcluster.net/task-inspector/#HrTLb_wUSzauU7so9BXYwQ/ and https://tools.taskcluster.net/task-inspector/#Y7HxWrbRQk2hNNwndDRw3w/ and both went green!

Closing this for now. Please reopen if any other issues come along.

Comment 15

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bf0558124b71

Comment 16

[Intermittent Failures Robot]

10 failures in 777 pushes (0.013 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-central: 10

Platform breakdown:
* android-4-0-armv7-api15: 4
* linux64: 2
* linux32: 2
* android-4-2-x86: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1348286&startday=2017-03-13&endday=2017-03-19&tree=all

Comment 17

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/releases/mozilla-beta/rev/c8bf3336431b