Closed Bug 1348286 Opened 3 years ago Closed 3 years ago

KeyError: 'target.awsy.tests.zip' on beetmover signing

Categories

(Release Engineering :: General, defect)

defect
Not set

Tracking

(firefox54 fixed, firefox55 fixed)

RESOLVED FIXED
Tracking Status
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: cbook, Assigned: mtabara)

References

()

Details

Attachments

(2 files)

Flags: needinfo?(bugspam.Callek)
mtabara: could you take a look, thanks!
Assignee: nobody → mtabara
Flags: needinfo?(bugspam.Callek)
Definitely. Feel free to assign anything beetmover related to me from now on ;-)
Status: NEW → ASSIGNED
Comment on attachment 8848637 [details]
Bug 1348286 - add awsy.tests within en-US mobile artifacts too.

https://reviewboard.mozilla.org/r/121520/#review123590

::: taskcluster/taskgraph/transforms/beetmover.py:59
(Diff revision 1)
>      "en-US/target.json",
>      "en-US/target.mochitest.tests.zip",
>      "en-US/target.mozinfo.json",
>      "en-US/target.reftest.tests.zip",
>      "en-US/target.talos.tests.zip",
> +    "en-US/target.awsy.tests.zip",

good eye!
Attachment #8848637 - Flags: review?(jlund) → review+
Comment on attachment 8848634 [details] [review]
Bug 1348286 - add missing target.awsy.tests.zip beetmoverscript templates. r=jlund

until the https://bugzilla.mozilla.org/show_bug.cgi?id=1331141 resolution is made, maybe we should at least leave an in-tree comment about required patch in beetmoverscript. e.g. at top of: https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/transforms/beetmover.py#18
Attachment #8848634 - Flags: review?(jlund) → review+
Pushed by mtabara@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bf0558124b71
add awsy.tests within en-US mobile artifacts too. r=jlund a=release DONTBUILD
(In reply to Jordan Lund (:jlund) from comment #6)
> Comment on attachment 8848634 [details] [review]
> Bug 1348286 - add missing target.awsy.tests.zip beetmoverscript templates.
> r=jlund
> 
> until the https://bugzilla.mozilla.org/show_bug.cgi?id=1331141 resolution is
> made, maybe we should at least leave an in-tree comment about required patch
> in beetmoverscript. e.g. at top of:
> https://dxr.mozilla.org/mozilla-central/source/taskcluster/taskgraph/
> transforms/beetmover.py#18

I agree! I've added a comment, thanks for the suggestion.
Bug 1331141 is something I'd really love to tackle in the future. Unification and single-sourcing everything in-tree would be awesome.
Comment on attachment 8848637 [details]
Bug 1348286 - add awsy.tests within en-US mobile artifacts too.

https://hg.mozilla.org/integration/mozilla-inbound/rev/bf0558124b71
Attachment #8848637 - Flags: checked-in+
Keywords: leave-open
https://hg.mozilla.org/build/puppet/rev/e39203f92424
Bug 1348286 - bump beetmoverscript in beetmoverworker. r=trivial
For some reason I missed adding the changes in the initial bump. Apologies for that.

https://hg.mozilla.org/build/puppet/rev/eed4e955a147
Bug 1348286 - bump beetmoverscript again in beetmoverworker. r=trivial
https://hg.mozilla.org/build/puppet/rev/0cd766403f7f
Bug 1348286 - bump beetmoverscript in beetmoverworker. r=trivial
Fixed beetmoverscript to take into account the `target.awsy.tests.zip` too. 

Retriggered https://tools.taskcluster.net/task-inspector/#HrTLb_wUSzauU7so9BXYwQ/ and https://tools.taskcluster.net/task-inspector/#Y7HxWrbRQk2hNNwndDRw3w/ and both went green!

Closing this for now. Please reopen if any other issues come along.
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Keywords: leave-open
Whiteboard: [checkin-needed-beta]
Component: General Automation → General
You need to log in before you can comment on or make changes to this bug.