1348322 - Fix the initial values of gVelocityCurveFunction

Status: RESOLVED FIXED

(Core :: Panning and Zooming, defect, P2)

Description

[Boris Chiou [:boris]]

The initial values of gVelocityCurveFunction [1] are not correct. They should be X1, Y1, X2, Y2.

[1] http://searchfox.org/mozilla-central/rev/006005beff40d377cfd2f69d3400633c5ff09127/gfx/layers/apz/src/AsyncPanZoomController.cpp#680-684

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 1348322 - Fix the initial values of gVelocityCurveFunction.

Review commit: https://reviewboard.mozilla.org/r/121458/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/121458/

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 8848552 [details]
Bug 1348322 - Fix the initial values of gVelocityCurveFunction.

https://reviewboard.mozilla.org/r/121458/#review123498

Thanks! Please make sure the try push is green before landing, there's a risk this might affect some of the gtests or APZ mochitests.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/110af17e4c5e
Fix the initial values of gVelocityCurveFunction. r=kats

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/110af17e4c5e

Comment 5

[Julien Cristau [:jcristau]]

Should we consider this fix for beta54?

Comment 6

[Kartikaya Gupta (email:[e-mail])]

For the record, I would be in favour of uplifting, since it's a small patch. Nobody has reported any negative impact on scrolling behaviour from this fix.

Comment 7

[Boris Chiou [:boris]]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #6)
> For the record, I would be in favour of uplifting, since it's a small patch.
> Nobody has reported any negative impact on scrolling behaviour from this fix.

Yes. Let's uplift it.

Comment 8

[Boris Chiou [:boris]]

Comment on attachment 8848552 [details]
Bug 1348322 - Fix the initial values of gVelocityCurveFunction.

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1091049
[User impact if declined]: Right now there is no feedback reply.
[Is this code covered by automated tests?]: No. This is a small patch to fix the initial value. No automated tests cover this now.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]:  No.
[List of other uplifts needed for the feature/fix]: Only this one.
[Is the change risky?]: No. This is a small patch and a bug fix.
[Why is the change risky/not risky?]: It is very simple, and only make the initial value be correct.
[String changes made/needed]: No.

Comment 9

[Gerry Chang [:gchang]]

Comment on attachment 8848552 [details]
Bug 1348322 - Fix the initial values of gVelocityCurveFunction.

A minor fix. Beta54+. Should be in 54 beta 1.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/4f8540793211

Comment 11

[Andrei Vaida [:avaida]]

(In reply to Boris Chiou [:boris] from comment #8)
> [Is this code covered by automated tests?]: No. This is a small patch to fix
> the initial value. No automated tests cover this now.
> [Has the fix been verified in Nightly?]: Yes.
> [Needs manual test from QE? If yes, steps to reproduce]:  No.

Setting qe-verify- based on Boris' assessment on manual testing needs.