1348345 - Hitting assertion with intel gfx driver version code

Status: RESOLVED DUPLICATE of bug 1325980

(Core :: Graphics, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

On my new windows box, I did a webrender-enabled debug build and tried running it. It crashes on startup, at [1]. I'm not sure exactly what the code is checking for, but I stepped through it and made a note of various things:
- eligibleDLLs is u"igdumdim64 igd10iumd64 igd10iumd64 igd12umd64 igdumdim32 igd10iumd32 igd10iumd32 igd12umd32"
- dllFileName is igd10umd64, which is nowhere to be found on my system, so the version for that remains at 0
- dllFileName2 is igd10iumd64, and there's a couple of copies of that on my system. There's one in Windows\System32\DriverStore\FileRepository\ki118901.inf_amd64_06659eeaf4ade97d\ which, according to the windows file properties dialog, has a file version of 21.20.16.4526. The other is in Windows\System32\DriverStore\FileRepository\ki120641.inf_amd64_e378dbe5c185380a\, which has a file version of 21.20.16.4590. 
- I'm not sure which of the above two versions of the file is used in gfxWindowsPlatform::GetDLLVersion, but the GetFileVersionInfoSizeW function call near the beginning returns 0, and so the function exits with "0.0.0.0" as the version.
- Therefore both dllNumericVersion and dllNumbericVersion2 resolve to 0 and the assertion is tripped.

[1] http://searchfox.org/mozilla-central/rev/006005beff40d377cfd2f69d3400633c5ff09127/widget/windows/GfxInfo.cpp#610

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Also the mDriverVersion[0] is 21.20.16.4590.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Fairly sure the problem here is that Firefox is expecting the igd10iumd64.dll file to be in a directory that LoadLibrary will look in, but it's not. Therefore the GetFileVersionInfoSizeW doesn't find it either. If I copy the 21.20.16.4590 version of the dll from the DriverStore folder into my $PWD, firefox starts up fine.

Comment 3

[Milan Sreckovic [:milan] (needinfo for best results)]

This is likely a duplicate of bug 1325980, which has a patch.  Kats will test to see if that patch fixes the problem.

Comment 4

[Kartikaya Gupta (email:[e-mail])]

Confirmed that the patch on bug 1325980 applied to my local debug build fixes the problem.